Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] rnv duplicates devices #1305

Closed
pauliusguzas opened this issue Dec 19, 2023 · 2 comments
Closed

[tvOS] rnv duplicates devices #1305

pauliusguzas opened this issue Dec 19, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pauliusguzas
Copy link
Collaborator

Describe the bug
rnv duplicates tvos devices

To Reproduce

  1. go to template-starter
  2. have tvos device connected
  3. do npx rnv run -p tvos -d -> rnv shows same device twice

Expected behavior
same device should be shown once

Screenshots or copy&paste

[ task ] <= [run] <= configure
[ task ] [run] getIosDeviceToRunOn[1]
[ task ] [run] getAppleDevices[1] ignoreDevices:false ignoreSimulators:true
✔ Executing: xcrun simctl list --json
[ warn ] [run] Could not find device Apple TV
? Select the device you want to launch on (Use arrow keys)
❯ Apple TV 4K (3) | TV 📺 | v: 16.6 | udid: fffe0:89:7e:64:d3:6ffff (device)
  Apple TV 4K (3) | TV 📺 | v: 16.6 | udid: addfcc35fc6fd800c67ce1ff49e48a85c206
a474 (device)

Desktop (please complete the following information):

  • OS: macOS Ventura
  • Node Version 18.14.2
  • RNV Version 1.0.0-rc.3
  • rnv/template-starter Version 1.0.0-rc.3
@pauliusguzas pauliusguzas added the bug Something isn't working label Dec 19, 2023
@mihaiblaga89 mihaiblaga89 added this to the 1.0 milestone Dec 20, 2023
@mihaiblaga89
Copy link
Contributor

@GabrieleKaceviciute are you able to replicate this? If so, can we have a pair session tomorrow to check it together? I can't seem to be able to replicate it

@GabrieleKaceviciute
Copy link
Collaborator

1.0.0-rc.9
NOTE: I noticed that if I open settings -> remotes and devices -> remote App and devices on TV, then rnv target list shows two devices (dublicate), if I close this settings window on TV -> rnv shows only one device

$ npx rnv target list -p tvos - Done! 🚀
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  SUMMARY | 1/23/2024, 11:12:25 AM                                        │
│  $ npx rnv target list -p tvos                                               │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 1.0.0-rc.9                                                │
│  Project Name ($package.name): @rnv/template-starter                         │
│  Project Version ($package.version): 1.0.0-rc.9                              │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): tvos                                                         │
│  Engine ($.platforms.tvos.engine): engine-core                               │
│  App Config (-c): template                                                   │
│  Build Scheme (-s): debug                                                    │
│  Env Info: darwin | x64 | node v18.19.0                                      │
│  Executed Time: 0h:0m:0s:355ms                                               │
│                                                                              │
│
tvos Targets:

 [1]> Office tvOS | TV 📺 | v: 16.5 | udid: fffe0:89:7e:62:0e:5dfff (device)
 [2]> Office tvOS | TV 📺 | v: 16.5 | udid: ffc8d3c7b9cffe4e3b057607030a3fc6b61d0b59 (device)
                                                                            │
└──────────────────────────────────────────────────────────────────────────────┘
➜  ~/Desktop/renative/packages/template-starter git:(24b5b363e)

all CLI log ->
output.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants