Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in the project name are changed to underscores and project cannot be runned #905

Closed
GabrieleKaceviciute opened this issue Aug 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GabrieleKaceviciute
Copy link
Collaborator

GabrieleKaceviciute commented Aug 23, 2022

Describe the bug
Spaces in the project name are changed to underscores and project cannot be runned

To Reproduce

  1. When doing ‘rnv new’ enter project name with space
  2. Do ‘rnv run’

Expected behavior
New project can be run

Screenshots or copy&paste

 🚀  SUMMARY | 8/23/2022, 4:56:28 PM                                         │
│  $ rnv run                                                                   │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 0.36.2-canary.3                                           │
│  Project Name ($package.name): space space                                   │
│  Project Version ($package.version): 0.1.0                                   │
│  Workspace ($.workspaceID): rnv                                              │
│  Build Scheme (-s): debug                                                    │
│  Env Info: darwin | x64 | node v16.14.0                                      │
│  Executed Time: 0h:0m:0s:647ms                                               │
│                                                                              │
│ [ warn ] COMMAND:

yarn

FAILED with ERROR:

error package.json: Name contains illegal characters
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Command failed with exit code 1: yarn
error package.json: Name contains illegal characters
yarn install v1.22.19
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

error package.json: Name contains illegal characters

Error: Command failed with exit code 1: yarn
error package.json: Name contains illegal characters
yarn install v1.22.19
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    at makeError (/Users/gabriele/.config/yarn/global/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/.config/yarn/global/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)


 Seems like your node_modules is corrupted by other libs. ReNative will try to fix it for you
│ [ error ] COMMAND:

yarn

FAILED with ERROR:

error package.json: Name contains illegal characters
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Command failed with exit code 1: yarn
error package.json: Name contains illegal characters
yarn install v1.22.19
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

error package.json: Name contains illegal characters

Error: Command failed with exit code 1: yarn
error package.json: Name contains illegal characters
yarn install v1.22.19
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    at makeError (/Users/gabriele/.config/yarn/global/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/.config/yarn/global/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)


│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

Desktop (please complete the following information):

  • OS: macOS Monterey 12.5
  • Node Version: 16.14.0
  • RNV Version: 0.36.1-canary.3
  • @rnv/template-starter: 0.36.1-canary.3
@GabrieleKaceviciute GabrieleKaceviciute added the bug Something isn't working label Aug 23, 2022
@pauliusguzas
Copy link
Collaborator

Also after successful project creating rnv shows that user should do 'cd space space' while the project was named 'space_space' automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants