Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLI-1258] Allow passing GitHub 'claims'/metadata to Authz #3435

Open
1 task done
markphelps opened this issue Sep 3, 2024 · 2 comments
Open
1 task done

[FLI-1258] Allow passing GitHub 'claims'/metadata to Authz #3435

markphelps opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
enhancement Created by Linear-GitHub Sync md Not too big, not too small

Comments

@markphelps
Copy link
Collaborator

markphelps commented Sep 3, 2024

Problem

Re: https://community.flipt.io/t/restrict-access-to-feature-flags-per-teams/41/2?u=mark

We currently map OIDC authn claims to a claims field in the metadata that is passed to our authz engine (ie: https://docs.flipt.io/guides/operation/authorization/rbac-with-keycloak), however we don't provide similar functionality for GitHub auth.

The user in the above linked Community post would like to create authz policies based on the authenticated user's GitHub team membership

Ideal Solution

Provide a way to pass an authenticated GitHub user's data to our authz engine. It would be nice if it were similar to how we do it in OIDC using something like claims, although I realize GitHub user response doesn't have a field called claims so maybe we need to name it something else?

https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28#get-the-authenticated-user

It also doesn't return the organization/teams of a user without doing another REST API call like we do to support Github allowed orgs/teams. But since we are already doing this at the authn stage, we could add this data to the metadata passed to authz.

Maybe we use something more generically named than claims for GitHub / other non-OIDC authn methods?

Search

  • I searched for other open and closed issues before opening this

Additional Context

No response

FLI-1258

@markphelps markphelps added the enhancement Created by Linear-GitHub Sync label Sep 3, 2024
@markphelps markphelps changed the title Allow passing GitHub 'claims'/metadata to Authz [FLI-1258] Allow passing GitHub 'claims'/metadata to Authz Sep 3, 2024
@GeorgeMac GeorgeMac added the md Not too big, not too small label Sep 27, 2024
@devumesh
Copy link
Contributor

devumesh commented Oct 27, 2024

Hi @markphelps , I would like to work on this issue

@erka
Copy link
Collaborator

erka commented Oct 27, 2024

You are welcome @devumesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Created by Linear-GitHub Sync md Not too big, not too small
Projects
Status: No status
Development

No branches or pull requests

4 participants