Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sokol_nuklear.h: how to know if nuklear handled an event #958

Closed
adamrt opened this issue Dec 19, 2023 · 3 comments
Closed

sokol_nuklear.h: how to know if nuklear handled an event #958

adamrt opened this issue Dec 19, 2023 · 3 comments

Comments

@adamrt
Copy link
Contributor

adamrt commented Dec 19, 2023

Hi is there a standard way to know if nuklear handled an event in the same way we can with imgui? void snk_handle_event(const sapp_event* ev); doesn't return anything and the state is isn't public. I have some ideas for a patch but wanted to make sure that I wasn't missing something obvious.

Thank you for such a rad library.

@adamrt adamrt changed the title sokol_nuklear.h: how to swallow events that nuklear handles sokol_nuklear.h: how to know if nuklear handled an event Dec 19, 2023
@floooh
Copy link
Owner

floooh commented Dec 19, 2023

Yeah you're right, there currently isn't a way to check. If you have an idea I'm open for a PR :)

(I think it's ok to just add a bool return value to the existing snk_handle_event() function, since existing code would still compile and work)

@adamrt
Copy link
Contributor Author

adamrt commented Dec 21, 2023

PR: #959

@floooh
Copy link
Owner

floooh commented Jan 3, 2024

Closing as fixed since PR #959 has been merged.

@floooh floooh closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants