Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors list sometimes links to "See:" annotation sites, not actual error sites #48

Closed
ilkka opened this issue Oct 24, 2016 · 3 comments
Closed

Comments

@ilkka
Copy link

ilkka commented Oct 24, 2016

For one project of mine, flow check outputs:

src/controllers/auth.js:49                                                                                                                                             
 49:   server.route(route.createPostRoute('/login', 'auth', {                                                                                                          
                    ^ call of method `createPostRoute`                                                                                                                 
 33:   config: RouteConfiguration                                                                                                                                      
               ^^^^^^^^^^^^^^^^^^ property `tags`. Property not found in. See: src/utils/route.js:33                                                                   
 49:   server.route(route.createPostRoute('/login', 'auth', {                                                                                                          
                                                            ^ object literal

The issue is totally valid, but the problem is that when I look at my Errors listing, it mixes up the "see also" and the actual error sites:

screen shot 2016-10-24 at 11 03 35

Instead of leading to src/controllers/auth.js, clicking on that errors leads me to where createPostRoute is defined, which is not helpful.

@gabelevi
Copy link
Contributor

Would #47 fix this for you? It adds an error for each file mentioned in a Flow error.

@ilkka
Copy link
Author

ilkka commented Oct 28, 2016

Yeah, I reckon it would! And if the entries appear in order, it would ensure the actual error site comes first in the list which is nice.

@orta
Copy link
Contributor

orta commented Dec 6, 2016

#47 won't fix this I think, it would still show just one error.

in microsoft/vscode#1927 (comment) they show that you can have a multi-line description, but only with one line showing in the "problems" section.

So perhaps that is the key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants