Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SHACL logical constraints not & and #321

Open
dpetran opened this issue Jan 6, 2023 · 2 comments
Open

Support SHACL logical constraints not & and #321

dpetran opened this issue Jan 6, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone
3.0.0-beta2

Comments

@dpetran
Copy link
Contributor

dpetran commented Jan 6, 2023

https://www.w3.org/TR/shacl/#core-components-logical

Transactions that violate logical constraints should return an error.
@dpetran dpetran added this to the 3.0.0-alpha1 milestone Jan 6, 2023
@aaj3f aaj3f modified the milestones: 3.0.0-alpha1, 3.0.0-alpha2 Jan 10, 2023
@aaj3f aaj3f modified the milestones: 3.0.0-alpha2, 3.0.0-alpha3 Mar 20, 2023
@zonotope zonotope added the beta release Required for Beta/Community Release label Apr 29, 2023
@zonotope zonotope modified the milestones: 3.0.0-alpha3, 3.0.0-beta1 Apr 29, 2023
@cap10morgan cap10morgan self-assigned this May 17, 2023
This was referenced May 18, 2023
Merged
Merged
@cap10morgan cap10morgan changed the title Support SHACL logical constraints Support SHACL logical constraints not & and Jun 1, 2023
@cap10morgan
Copy link
Contributor

Splitting out support for or and xone into separate issues. Mostly because the implementation work for not & and ended up being quite a bit more than we'd thought it would be.

This was referenced Jun 1, 2023
Open
Open
@cap10morgan
Copy link
Contributor

Deprioritizing this for now, so here are my notes on what I've done / discovered so far:

  • Basic sh:not support is on main but it only supports PropertyShapes, not NodeShapes. The spec calls for both, so we're non-compliant for now.
  • sh:and isn't really useful from what I can tell w/o NodeShape support (for extending those shapes w/ additional properties) so a partial implementation w/ only PropertyShape support doesn't seem worthwhile here.
  • Supporting NodeShapes embedded in other NodeShapes required a more substantial refactor of the SHACL code than seemed worth prioritizing at the time.
  • The other SHACL logical constraints (sh:or and sh:xone) are also supposed to support NodeShapes, but they would be useful w/ PropertyShape support alone. So that could be an option for a first pass down the road.

@cap10morgan cap10morgan modified the milestones: 3.0.0-beta1, 3.0.0-beta2 Jun 5, 2023
@cap10morgan cap10morgan added enhancement New feature or request and removed beta release Required for Beta/Community Release labels Jun 6, 2023
@cap10morgan cap10morgan removed their assignment Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0-beta2
Development

No branches or pull requests
4 participants
@cap10morgan @zonotope @aaj3f @dpetran