From e5ce761ca7a56439c73bc767d5c7b7ceb0bbfbec Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Fri, 26 Oct 2018 17:36:28 -0700 Subject: [PATCH] Fix buildbots by not adding unsupported flags when building on Mac. --- build/config/compiler/BUILD.gn | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index ff9956123c..2e67244fcb 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -415,9 +415,12 @@ config("compiler") { "-funwind-tables", "-fno-short-enums", "-nostdinc++", - "-Wa,--noexecstack", + + # TODO(kf6gpe): -Wa,--noexecstack is not supported by the Mac toolchain + # with targeting Android. https://github.com/flutter/flutter/issues/23606 + # "-Wa,--noexecstack", "-Wformat", - "-Wformat-security" + "-Wformat-security", ] if (!is_clang) { # Clang doesn't support these flags.