From 7d9750bc46cfd207c067e253802721ad4cf52765 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Fri, 5 Oct 2018 23:11:07 -0700 Subject: [PATCH] Fix race! --- shell/platform/darwin/ios/platform_view_ios.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/shell/platform/darwin/ios/platform_view_ios.mm b/shell/platform/darwin/ios/platform_view_ios.mm index 768a4b0696dc4..0d8da582f3b3c 100644 --- a/shell/platform/darwin/ios/platform_view_ios.mm +++ b/shell/platform/darwin/ios/platform_view_ios.mm @@ -50,7 +50,10 @@ accessibility_bridge_.reset( new AccessibilityBridge(static_cast(owner_controller_.get().view), this)); } - NotifyCreated(); + // Do not call `NotifyCreated()` here - let FlutterViewController take care + // of that when its Viewport is sized. If `NotifyCreated()` is called here, + // it can occasionally get invoked before the viewport is sized resulting in + // a framebuffer that will not be able to completely attach. } }