From 66aa183137b91ebc93af04aff8cd094d23c52ded Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Tue, 6 Feb 2024 01:27:45 +0000 Subject: [PATCH] [Impeller] Do not skip the GLES render pass if the command list is empty The render pass may need to apply other changes such as painting the clear color. See https://github.com/flutter/flutter/issues/142639 --- impeller/renderer/backend/gles/render_pass_gles.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/impeller/renderer/backend/gles/render_pass_gles.cc b/impeller/renderer/backend/gles/render_pass_gles.cc index 7a1cfea53322a..0bb937320c384 100644 --- a/impeller/renderer/backend/gles/render_pass_gles.cc +++ b/impeller/renderer/backend/gles/render_pass_gles.cc @@ -151,10 +151,6 @@ struct RenderPassData { const std::shared_ptr& tracer) { TRACE_EVENT0("impeller", "RenderPassGLES::EncodeCommandsInReactor"); - if (commands.empty()) { - return true; - } - const auto& gl = reactor.GetProcTable(); #ifdef IMPELLER_DEBUG tracer->MarkFrameStart(gl); @@ -517,9 +513,6 @@ bool RenderPassGLES::OnEncodeCommands(const Context& context) const { if (!IsValid()) { return false; } - if (commands_.empty()) { - return true; - } const auto& render_target = GetRenderTarget(); if (!render_target.HasColorAttachment(0u)) { return false;