Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skwasm] Always do backdrop filter operation even if empty. #54844

Merged
merged 2 commits into from
Aug 28, 2024
Merged

[skwasm] Always do backdrop filter operation even if empty. #54844

merged 2 commits into from
Aug 28, 2024

Conversation

eyebrowsoffire
Copy link
Contributor

This is a partial fix for flutter/flutter#152026

We are still blocked on https://g-issues.skia.org/issues/362552959 for things to be completely working.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 28, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #54844 at sha 5d4fc57

yjbanov
yjbanov approved these changes Aug 28, 2024
View reviewed changes
lib/web_ui/lib/src/engine/layers.dart Outdated
@@ -414,6 +446,10 @@ abstract class LayerOperation {
void post(SceneCanvas canvas, ui.Rect contentRect);

PlatformViewStyling createPlatformViewStyling();

// Most operations don't need to actually be performed at all if they don't
// contain any pictures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making it a full /// dart doc, and also include the explanation of the effect this field has (the context is nice though; let's keep it).

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit auto-submit bot merged commit d2997de into flutter:main Aug 28, 2024
30 checks passed
@eyebrowsoffire eyebrowsoffire mentioned this pull request Aug 28, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
c46f78f 
…flutter/engine#54844)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
f7e159a 
…flutter/engine#54844)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
5a79b60 
…flutter/engine#54844)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
b873cbd 
…flutter/engine#54844)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
7cf9720 
…flutter/engine#54844)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
4439b06 
…flutter/engine#54844)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
d2997dec5 [skwasm] Always do backdrop filter operation even if empty. (…
7966681 
…flutter/engine#54844)
zanderso added a commit to flutter/flutter that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll @zanderso
Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions) (#…
7e9a622 
…154316)

Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions)

flutter/engine@8d248ae...f48ecf5

2024-08-29 [email protected] [Impeller] Use multiple command
buffers for blur submission. (flutter/engine#54846)
2024-08-29 [email protected] Roll Skia from 0d8d9d2974fa to
e37b6b198016 (1 revision) (flutter/engine#54854)
2024-08-29 [email protected] Remove
`--disable-dart-dev` across `flutter/engine`. (flutter/engine#54845)
2024-08-28 [email protected] Roll Fuchsia Test Scripts from
vIJGWtHj4Rdku9Ayv... to NWpblL_DFACOx_Spi... (flutter/engine#54852)
2024-08-28 [email protected] [Impeller] fix clip culling with exp
canvas. (flutter/engine#54701)
2024-08-28 [email protected] Roll Dart SDK from
bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) (flutter/engine#54851)
2024-08-28 [email protected] Roll Skia from d55406ca32e9 to
0d8d9d2974fa (4 revisions) (flutter/engine#54850)
2024-08-28 [email protected] [skwasm] Always do backdrop filter
operation even if empty. (flutter/engine#54844)
2024-08-28 [email protected]
Migrate`header_guard_check` to `package:test`. (flutter/engine#54811)
2024-08-28 [email protected] Roll Fuchsia GN SDK from
OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54848)
2024-08-28 [email protected] Roll Skia from cd3d3daafe55 to
d55406ca32e9 (10 revisions) (flutter/engine#54847)
2024-08-28 [email protected] [Impeller] ensure that srcOver to
src conversion takes stroke coverage into account.
(flutter/engine#54817)
2024-08-28 [email protected] Roll Fuchsia GN SDK from
ALNKvSVWQSpw1uxPy... to OKGFjciA5Vd0TQks4... (flutter/engine#54840)
2024-08-28 [email protected] Remove scorecards and
other bading we are no longer tracking/links are borked
(flutter/engine#54839)
2024-08-28 [email protected] Compile dart2wasm modules using the JS
runtime exported compileStreaming (flutter/engine#51488)
2024-08-28 [email protected] Roll Dart SDK from
183b9e21b706 to bc3dad16b2d3 (1 revision) (flutter/engine#54838)
2024-08-28 [email protected] Ignore generated fixture
`.dill.deps` files. (flutter/engine#54836)
2024-08-28 [email protected]
[fuchsia] use the api-level from gn-sdk (flutter/engine#54740)
2024-08-28 [email protected] [Impeller] port clip stack fixes to
new canvas. (flutter/engine#54727)
2024-08-28 [email protected] [Impeller] fall back to path
rendering on thick paths. (flutter/engine#54822)
2024-08-28 [email protected] Roll Fuchsia Linux SDK from
BCqzoTS_Sz6-AaSii... to ZL8AvfXX5LFIH1LYN... (flutter/engine#54834)
2024-08-28 [email protected] Roll Skia from ca108745b1de to
cd3d3daafe55 (1 revision) (flutter/engine#54832)
2024-08-28 [email protected] Roll Dart SDK from
42ddf2278114 to 183b9e21b706 (1 revision) (flutter/engine#54830)
2024-08-28 [email protected] Roll Dart SDK from
b519f85c3076 to 42ddf2278114 (1 revision) (flutter/engine#54829)
2024-08-28 [email protected] Roll Fuchsia GN SDK from
OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54827)
2024-08-28 [email protected] Roll Skia from 41cb13f65fe6 to
ca108745b1de (1 revision) (flutter/engine#54828)
2024-08-28 [email protected] Roll Skia from 259010335a55 to
41cb13f65fe6 (2 revisions) (flutter/engine#54826)
2024-08-28 [email protected] Roll Skia from 505fb55cd044 to
259010335a55 (1 revision) (flutter/engine#54823)
2024-08-28 [email protected] Roll Dart SDK from
8334290a421b to b519f85c3076 (1 revision) (flutter/engine#54821)
2024-08-28 [email protected] Roll Skia from 84e4a69da303 to
505fb55cd044 (1 revision) (flutter/engine#54819)
2024-08-27 [email protected] [Impeller] Increase host buffer
arena count to 4. (flutter/engine#54808)
2024-08-27 [email protected] Synchronize accounting for render op depths
(flutter/engine#54794)
2024-08-27 [email protected] Fix broken links
in `docs/` (flutter/engine#54815)
2024-08-27 [email protected] [Impeller] Don't override user
specification on Vulkan validation in unopt. (flutter/engine#54816)
2024-08-27 [email protected] Manual roll Dart SDK from
b81b344a194f to 8334290a421b (12 revisions) (flutter/engine#54813)
2024-08-27 [email protected] Roll Skia from 77017d30a455 to
84e4a69da303 (3 revisions) (flutter/engine#54812)
2024-08-27 [email protected] [Impeller] Clarify where to put the
metadata in the manifest. (flutter/engine#54814)
2024-08-27 [email protected] [Impeller] Use infinite swapchain
present timeouts to avoid logspam. (flutter/engine#54810)
2024-08-27 [email protected] Roll Skia from 2e1eea538014 to
77017d30a455 (2 revisions) (flutter/engine#54809)
2024-08-27 [email protected] Roll Skia from a2e2eb292492 to
2e1eea538014 (4 revisions) (flutter/engine#54806)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from BCqzoTS_Sz6- to ZL8AvfXX5LFI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
...

---------

Co-authored-by: Zachary Anderson <[email protected]>
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @zanderso @Buchimi
Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions) (f…
d5ff689 
…lutter#154316)

Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions)

flutter/engine@8d248ae...f48ecf5

2024-08-29 [email protected] [Impeller] Use multiple command
buffers for blur submission. (flutter/engine#54846)
2024-08-29 [email protected] Roll Skia from 0d8d9d2974fa to
e37b6b198016 (1 revision) (flutter/engine#54854)
2024-08-29 [email protected] Remove
`--disable-dart-dev` across `flutter/engine`. (flutter/engine#54845)
2024-08-28 [email protected] Roll Fuchsia Test Scripts from
vIJGWtHj4Rdku9Ayv... to NWpblL_DFACOx_Spi... (flutter/engine#54852)
2024-08-28 [email protected] [Impeller] fix clip culling with exp
canvas. (flutter/engine#54701)
2024-08-28 [email protected] Roll Dart SDK from
bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) (flutter/engine#54851)
2024-08-28 [email protected] Roll Skia from d55406ca32e9 to
0d8d9d2974fa (4 revisions) (flutter/engine#54850)
2024-08-28 [email protected] [skwasm] Always do backdrop filter
operation even if empty. (flutter/engine#54844)
2024-08-28 [email protected]
Migrate`header_guard_check` to `package:test`. (flutter/engine#54811)
2024-08-28 [email protected] Roll Fuchsia GN SDK from
OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54848)
2024-08-28 [email protected] Roll Skia from cd3d3daafe55 to
d55406ca32e9 (10 revisions) (flutter/engine#54847)
2024-08-28 [email protected] [Impeller] ensure that srcOver to
src conversion takes stroke coverage into account.
(flutter/engine#54817)
2024-08-28 [email protected] Roll Fuchsia GN SDK from
ALNKvSVWQSpw1uxPy... to OKGFjciA5Vd0TQks4... (flutter/engine#54840)
2024-08-28 [email protected] Remove scorecards and
other bading we are no longer tracking/links are borked
(flutter/engine#54839)
2024-08-28 [email protected] Compile dart2wasm modules using the JS
runtime exported compileStreaming (flutter/engine#51488)
2024-08-28 [email protected] Roll Dart SDK from
183b9e21b706 to bc3dad16b2d3 (1 revision) (flutter/engine#54838)
2024-08-28 [email protected] Ignore generated fixture
`.dill.deps` files. (flutter/engine#54836)
2024-08-28 [email protected]
[fuchsia] use the api-level from gn-sdk (flutter/engine#54740)
2024-08-28 [email protected] [Impeller] port clip stack fixes to
new canvas. (flutter/engine#54727)
2024-08-28 [email protected] [Impeller] fall back to path
rendering on thick paths. (flutter/engine#54822)
2024-08-28 [email protected] Roll Fuchsia Linux SDK from
BCqzoTS_Sz6-AaSii... to ZL8AvfXX5LFIH1LYN... (flutter/engine#54834)
2024-08-28 [email protected] Roll Skia from ca108745b1de to
cd3d3daafe55 (1 revision) (flutter/engine#54832)
2024-08-28 [email protected] Roll Dart SDK from
42ddf2278114 to 183b9e21b706 (1 revision) (flutter/engine#54830)
2024-08-28 [email protected] Roll Dart SDK from
b519f85c3076 to 42ddf2278114 (1 revision) (flutter/engine#54829)
2024-08-28 [email protected] Roll Fuchsia GN SDK from
OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54827)
2024-08-28 [email protected] Roll Skia from 41cb13f65fe6 to
ca108745b1de (1 revision) (flutter/engine#54828)
2024-08-28 [email protected] Roll Skia from 259010335a55 to
41cb13f65fe6 (2 revisions) (flutter/engine#54826)
2024-08-28 [email protected] Roll Skia from 505fb55cd044 to
259010335a55 (1 revision) (flutter/engine#54823)
2024-08-28 [email protected] Roll Dart SDK from
8334290a421b to b519f85c3076 (1 revision) (flutter/engine#54821)
2024-08-28 [email protected] Roll Skia from 84e4a69da303 to
505fb55cd044 (1 revision) (flutter/engine#54819)
2024-08-27 [email protected] [Impeller] Increase host buffer
arena count to 4. (flutter/engine#54808)
2024-08-27 [email protected] Synchronize accounting for render op depths
(flutter/engine#54794)
2024-08-27 [email protected] Fix broken links
in `docs/` (flutter/engine#54815)
2024-08-27 [email protected] [Impeller] Don't override user
specification on Vulkan validation in unopt. (flutter/engine#54816)
2024-08-27 [email protected] Manual roll Dart SDK from
b81b344a194f to 8334290a421b (12 revisions) (flutter/engine#54813)
2024-08-27 [email protected] Roll Skia from 77017d30a455 to
84e4a69da303 (3 revisions) (flutter/engine#54812)
2024-08-27 [email protected] [Impeller] Clarify where to put the
metadata in the manifest. (flutter/engine#54814)
2024-08-27 [email protected] [Impeller] Use infinite swapchain
present timeouts to avoid logspam. (flutter/engine#54810)
2024-08-27 [email protected] Roll Skia from 2e1eea538014 to
77017d30a455 (2 revisions) (flutter/engine#54809)
2024-08-27 [email protected] Roll Skia from a2e2eb292492 to
2e1eea538014 (4 revisions) (flutter/engine#54806)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from BCqzoTS_Sz6- to ZL8AvfXX5LFI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
...

---------

Co-authored-by: Zachary Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyebrowsoffire @yjbanov