Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devicelab "smoke_catalina_hot_mode_dev_cycle_ios__benchmark" failure "Error while starting Kernel isolate task" #71178

Closed
christopherfujino opened this issue Nov 24, 2020 · 15 comments · Fixed by #71180 or #73589
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P2 Important issues not at the top of the work list

Comments

@christopherfujino
Copy link
Member

christopherfujino commented Nov 24, 2020

https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahFmbHV0dGVyLWRhc2hib2FyZHJfCxIJQ2hlY2tsaXN0Ij9mbHV0dGVyL2ZsdXR0ZXIvbWFzdGVyL2IxOGYxYjgxZmUwOWExZjJiZWEzOWVhYWM5Y2M3MDllMWFjNjAwY2YMCxIEVGFzaxiAgJitlZL0Cww

2020-11-24T13:18:51.833071: stdout: Performing hot restart...                                       
2020-11-24T13:18:51.833173: stdout: Restarted application in 1,622ms.
2020-11-24T13:19:01.844560: stdout: Benchmarking hot reload
2020-11-24T13:19:02.336088: stdout: Performing hot reload...                                        
2020-11-24T13:19:02.341727: stdout: Reloaded 0 libraries in 491ms.
2020-11-24T13:19:02.344558: stdout: 
2020-11-24T13:19:06.671623: stderr: Hot reload was rejected:
2020-11-24T13:19:06.671728: stderr: Error while starting Kernel isolate task.
stderr: Try performing a hot restart instead.
2020-11-24T13:19:06.672008: stdout: Performing hot reload...                                        
2020-11-24T13:19:06.672084: stdout: Try again after fixing the above error(s).
2020-11-24T14:16:27.981250: Task execution finished
@christopherfujino
Copy link
Member Author

christopherfujino commented Nov 24, 2020

This could have been broken by any of the following 3 engine rolls:

The test hasn't been back filled for any of these engine rolls yet:
Screen Shot 2020-11-24 at 3 05 31 PM

@iskakaushik
Copy link
Contributor

I'm pausing the engine->framework roller until this is resolved.

@christopherfujino
Copy link
Member Author

@christopherfujino
Copy link
Member Author

Since this test repeatedly fails on b18f1b8, while it passed on the previous, I landed a revert to see if it will fix the tree #71180

@keyonghan
Copy link
Contributor

Unfortunately it hangs with the same error on the revert.

@christopherfujino
Copy link
Member Author

Ok, I will re-land goderbauer's commit.

@christopherfujino
Copy link
Member Author

This test was marked flaky in #71188

@Piinks
Copy link
Contributor

Piinks commented Dec 1, 2020

I am going to downgrade this since it is not breaking the build anymore in its flaky state. Currently tasks are backed up so we are waiting to evaluate if the flakiness has persisted.

@Piinks Piinks added P1 and removed P0 Critical issues such as a build break or regression labels Dec 1, 2020
@jonahwilliams
Copy link
Member

The error message comes from https://github.com/dart-lang/sdk/blob/55bb15a8cbbe7c5ff2242d74c5e18370ba9b6922/runtime/vm/kernel_isolate.cc#L1016

Unfortunately it doesn't tell us much about what failed. Ideally there would be a verbose mode that would include more error logs during the hot reload. @zanderso @aam do you know what flag controls OS::PrintErr?

@zanderso
Copy link
Member

zanderso commented Dec 2, 2020

The logging in that file is guarded by the Dart VM command line flag --trace-kernel.

@aam
Copy link
Member

aam commented Dec 2, 2020

@jonahwilliams asked:

do you know what flag controls OS::PrintErr?

There is no generic flag for that.
You can try adding --trace-reload and --trace-reload-verbose flags that enable more trace prints during hot reload to https://github.com/flutter/engine/blob/master/runtime/dart_vm.cc#L63.

@jonahwilliams
Copy link
Member

The latest run of this is passing

@jonahwilliams
Copy link
Member

Test is still passing, might have been a device issue? I'm lowering the priority but still plan to up the verbosity

@jonahwilliams jonahwilliams added P2 Important issues not at the top of the work list and removed P1 labels Dec 3, 2020
@jonahwilliams
Copy link
Member

removing assignment because I will be OOO

@jonahwilliams jonahwilliams removed their assignment Dec 4, 2020
@github-actions
Copy link

github-actions bot commented Aug 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
@flutter-triage-bot flutter-triage-bot bot added the c: flake Tests that sometimes, but not always, incorrectly pass label Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P2 Important issues not at the top of the work list
Projects
None yet
8 participants