Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartdoc can't handle sky_engine containing SDK sources #9468

Closed
jcollins-g opened this issue Apr 19, 2017 · 2 comments
Closed

dartdoc can't handle sky_engine containing SDK sources #9468

jcollins-g opened this issue Apr 19, 2017 · 2 comments
Assignees

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Apr 19, 2017

dartdoc doesn't generate good docs (see http://docs.flutter.io and missing 'empty' link, "sky_engine" library, etc) because it has lost track of where the Dart SDK is. This is likely related to a known issue in dartdoc (dart-lang/dartdoc#1367) where we don't obey analysis option files or the other hints that the analyzer uses to figure these things out.

I believe it is likely that this PR triggered the problem: flutter/engine#3575.

This interacts badly with the canonicalization improvements in dartdoc 0.10.0, because it now matters more to dartdoc that it can find the SDK. @sethladd @Hixie @devoncarew

@jcollins-g jcollins-g changed the title dartdoc can't handle sky_engine containing SDK packages dartdoc can't handle sky_engine containing SDK sources Apr 19, 2017
@jcollins-g jcollins-g self-assigned this Apr 24, 2017
@jcollins-g
Copy link
Contributor Author

dart-lang/dartdoc#1385 addresses this

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant