From 41c512cdd28ec268fcc103388d9cc0dc88f6e69a Mon Sep 17 00:00:00 2001 From: yamarkz Date: Fri, 22 May 2020 00:11:29 +0900 Subject: [PATCH 1/3] Google_sign_in: Fix "serverAuthCode getToken" on iOS --- .../google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m b/packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m index f621d1e68312..f42ea575d392 100644 --- a/packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m +++ b/packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m @@ -112,6 +112,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result result(error != nil ? getFlutterError(error) : @{ @"idToken" : authentication.idToken, @"accessToken" : authentication.accessToken, + @"serverAuthCode" : currentUser.serverAuthCode, }); }]; } else if ([call.method isEqualToString:@"signOut"]) { @@ -223,8 +224,7 @@ - (void)signIn:(GIDSignIn *)signIn @"displayName" : user.profile.name ?: [NSNull null], @"email" : user.profile.email ?: [NSNull null], @"id" : user.userID ?: [NSNull null], - @"photoUrl" : [photoUrl absoluteString] ?: [NSNull null], - @"serverAuthCode" : user.serverAuthCode ?: [NSNull null] + @"photoUrl" : [photoUrl absoluteString] ?: [NSNull null] } error:nil]; } From 595835c8602c8259fc5d40fdc8dd6dc70fe668f4 Mon Sep 17 00:00:00 2001 From: yamarkz Date: Fri, 22 May 2020 00:29:42 +0900 Subject: [PATCH 2/3] Version bump --- packages/google_sign_in/google_sign_in/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in/pubspec.yaml b/packages/google_sign_in/google_sign_in/pubspec.yaml index 8e520334192c..a7de7a663a9e 100644 --- a/packages/google_sign_in/google_sign_in/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in/pubspec.yaml @@ -2,7 +2,7 @@ name: google_sign_in description: Flutter plugin for Google Sign-In, a secure authentication system for signing in with a Google account on Android and iOS. homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in -version: 4.5.1 +version: 4.5.2 flutter: plugin: From 5e8466c0aa6c419346a81c4fcc7e3709724591d3 Mon Sep 17 00:00:00 2001 From: yamarkz Date: Fri, 22 May 2020 00:35:16 +0900 Subject: [PATCH 3/3] Update CHANGELOG.md --- packages/google_sign_in/google_sign_in/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/google_sign_in/google_sign_in/CHANGELOG.md b/packages/google_sign_in/google_sign_in/CHANGELOG.md index 8fbba4944df7..47c374c31923 100644 --- a/packages/google_sign_in/google_sign_in/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in/CHANGELOG.md @@ -1,3 +1,7 @@ +## 4.5.2 + +* Fix the getToken method used in serverAuthCode on iOS. + ## 4.5.1 * Add note on Apple sign in requirement in README.