From d5b8173c880d22a5046924ba893cf3769d262478 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Thu, 4 Feb 2021 08:01:39 -0800 Subject: [PATCH 1/4] Add a note about Plus plugins to CONTRIBUTING.md Adds a prominent note to CONTRIBUTING.md about the new policy regarding PRs for plugins for which there is a Flutter Community Plus Plugins equivalent. --- CONTRIBUTING.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b763320b67c9..a5dff36de174 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,6 +5,25 @@ _See also: [Flutter's code of conduct](https://github.com/flutter/flutter/blob/master/CODE_OF_CONDUCT.md)_ +## Important note + +As of January 2021, we are no longer accepting non-critical PRs for plugins +for which there is a corresponding [Flutter Community Plus +Plugin](https://plus.fluttercommunity.dev/), as we hope that in time we're able +to transition users to those versions of the plugins. If you have a feature +addition or other non-critical PR for any of the following plugins, we +encourage you to submit it +[there](https://github.com/fluttercommunity/plus_plugins/pulls) instead: +- `android_alarm_manager` +- `android_intent` +- `battery` +- `connectivity` +- `device_info` +- `wifi_info_flutter` (corresponds to `network_info_plus`) +- `package_info` +- `sensors` +- `share` + ## Things you will need From cc2707ac867ee65a9c901a7009037d3668c1eb69 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Thu, 4 Feb 2021 08:15:41 -0800 Subject: [PATCH 2/4] Clarify "critical" --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a5dff36de174..b9a9431d5df0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,9 +10,9 @@ _See also: [Flutter's code of conduct](https://github.com/flutter/flutter/blob/m As of January 2021, we are no longer accepting non-critical PRs for plugins for which there is a corresponding [Flutter Community Plus Plugin](https://plus.fluttercommunity.dev/), as we hope that in time we're able -to transition users to those versions of the plugins. If you have a feature -addition or other non-critical PR for any of the following plugins, we -encourage you to submit it +to transition users to those versions of the plugins. If you have a PR for +something other than a critical issue (crashes, build failures, null safety, etc.) +for any of the following plugins, we encourage you to submit it [there](https://github.com/fluttercommunity/plus_plugins/pulls) instead: - `android_alarm_manager` - `android_intent` From 87a105fe85a546d666dac9e42f3d3c6147c967db Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Thu, 4 Feb 2021 08:18:11 -0800 Subject: [PATCH 3/4] Fix plugin order --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b9a9431d5df0..8fea85bcc4a9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,10 +19,10 @@ for any of the following plugins, we encourage you to submit it - `battery` - `connectivity` - `device_info` -- `wifi_info_flutter` (corresponds to `network_info_plus`) - `package_info` - `sensors` - `share` +- `wifi_info_flutter` (corresponds to `network_info_plus`) ## Things you will need From 34f76cf41fdd4707863003c26fe0cfdc1dd40341 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Thu, 4 Feb 2021 09:19:13 -0800 Subject: [PATCH 4/4] Reword --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8fea85bcc4a9..6c4abd0cb516 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ _See also: [Flutter's code of conduct](https://github.com/flutter/flutter/blob/m As of January 2021, we are no longer accepting non-critical PRs for plugins for which there is a corresponding [Flutter Community Plus -Plugin](https://plus.fluttercommunity.dev/), as we hope that in time we're able +Plugin](https://plus.fluttercommunity.dev/), as we hope in time to be able to transition users to those versions of the plugins. If you have a PR for something other than a critical issue (crashes, build failures, null safety, etc.) for any of the following plugins, we encourage you to submit it