From 662d076f21a15ec8802e3bdd507b01cd20147f75 Mon Sep 17 00:00:00 2001 From: Guilherme Girotto Date: Fri, 5 Mar 2021 15:54:30 -0300 Subject: [PATCH 1/7] [google_sign_in] Updates google_sign_in_platform_interfaces to parametrize `clientId` in `init` function --- .../lib/src/method_channel_google_sign_in.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index b36676e2376d..ea2426159e21 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -30,6 +30,7 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { 'signInOption': signInOption.toString(), 'scopes': scopes, 'hostedDomain': hostedDomain, + 'clientId': clientId, }); } From 9cbf23a1573a4a44d1287b41f71e990733a345b9 Mon Sep 17 00:00:00 2001 From: Guilherme Girotto Date: Fri, 5 Mar 2021 15:56:19 -0300 Subject: [PATCH 2/7] Bumps version and updates CHANGELOG --- .../google_sign_in_platform_interface/CHANGELOG.md | 3 +++ .../google_sign_in_platform_interface/pubspec.yaml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md index dd6c22fbef29..d4b0c24d9439 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md @@ -1,3 +1,6 @@ +## 2.0.1 +* Updates `init` function in `MethodChannelGoogleSignIn` to parametrize `clientId` property. + ## 2.0.0 * Migrate to null-safety. diff --git a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml index 56b4033dcb88..195bff28d992 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the google_sign_in plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 2.0.0 +version: 2.0.1 dependencies: flutter: From afb65c2e55216aed363bf52ff71a64fc4792cff8 Mon Sep 17 00:00:00 2001 From: Guilherme Girotto Date: Fri, 5 Mar 2021 17:09:06 -0300 Subject: [PATCH 3/7] Updates tests to support clientId argument --- .../test/method_channel_google_sign_in_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index 325f0c10a6ab..9447cd0edfc4 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -100,11 +100,12 @@ void main() { hostedDomain: 'example.com', scopes: ['two', 'scopes'], signInOption: SignInOption.games, - clientId: 'UNUSED!'); + clientId: 'fakeClientId'); }: isMethodCall('init', arguments: { 'hostedDomain': 'example.com', 'scopes': ['two', 'scopes'], 'signInOption': 'SignInOption.games', + 'clientId': 'fakeClientId', }), () { googleSignIn.getTokens( From baa319356eba0525d4477c1b96e33cbe629516a1 Mon Sep 17 00:00:00 2001 From: Guilherme Girotto Date: Fri, 5 Mar 2021 17:30:09 -0300 Subject: [PATCH 4/7] Bumps version from 2.0.1 to 2.1.0 in pubspec.yaml and CHANGELOG --- .../google_sign_in_platform_interface/CHANGELOG.md | 2 +- .../google_sign_in_platform_interface/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md index d4b0c24d9439..00e52395d7f9 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md @@ -1,4 +1,4 @@ -## 2.0.1 +## 2.1.0 * Updates `init` function in `MethodChannelGoogleSignIn` to parametrize `clientId` property. ## 2.0.0 diff --git a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml index 195bff28d992..d120ad34bfc7 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the google_sign_in plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 2.0.1 +version: 2.1.0 dependencies: flutter: From 86e1a99120b5f67bca6ccafa15f56572a726cd33 Mon Sep 17 00:00:00 2001 From: Chris Yang Date: Fri, 5 Mar 2021 17:35:28 -0800 Subject: [PATCH 5/7] Update packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md --- .../google_sign_in_platform_interface/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md index 00e52395d7f9..b1883ad0d1a3 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md @@ -1,4 +1,5 @@ ## 2.1.0 + * Updates `init` function in `MethodChannelGoogleSignIn` to parametrize `clientId` property. ## 2.0.0 From 42c7e254a3c4da13817918a3d1cdf94bb0788432 Mon Sep 17 00:00:00 2001 From: Chris Yang Date: Fri, 5 Mar 2021 17:38:23 -0800 Subject: [PATCH 6/7] Update CHANGELOG.md --- .../google_sign_in_platform_interface/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md index b1883ad0d1a3..ee43db685339 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md @@ -1,4 +1,4 @@ -## 2.1.0 +## 2.0.1 * Updates `init` function in `MethodChannelGoogleSignIn` to parametrize `clientId` property. From adb3ed2f7b7334d9b96c0e6c272c2595a4efa398 Mon Sep 17 00:00:00 2001 From: Chris Yang Date: Fri, 5 Mar 2021 17:38:32 -0800 Subject: [PATCH 7/7] Update pubspec.yaml --- .../google_sign_in_platform_interface/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml index d120ad34bfc7..195bff28d992 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the google_sign_in plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 2.1.0 +version: 2.0.1 dependencies: flutter: