Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable rfw tests #151659

Open
zanderso opened this issue Jul 12, 2024 · 1 comment · May be fixed by flutter/tests#415
Open

Fix and re-enable rfw tests #151659

zanderso opened this issue Jul 12, 2024 · 1 comment · May be fixed by flutter/tests#415
Labels
a: tests "flutter test", flutter_test, or one of our tests c: disabled test Tracks the restoration of a disabled test p: rfw Remote Flutter Widgets package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@zanderso
Copy link
Member

They were disabled in flutter/tests#386 for #151611.
@zanderso zanderso added the p: rfw Remote Flutter Widgets package label Jul 12, 2024
This was referenced Jul 12, 2024
Closed
Merged
@zanderso zanderso changed the title Re-enable rfw tests Fix and re-enable rfw tests Jul 12, 2024
@zanderso
Copy link
Member Author

cc @Hixie @goderbauer owners of the flutter_packages customer test.

@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team and removed in triage Presently being triaged by the triage team labels Jul 15, 2024
@stuartmorgan stuartmorgan added P1 High-priority issues at the top of the work list c: disabled test Tracks the restoration of a disabled test triaged-ecosystem Triaged by Ecosystem team labels Jul 16, 2024
@victoreronmosele victoreronmosele mentioned this issue Jul 17, 2024
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 7, 2024
@victoreronmosele
[rfw] Increase tolerance for material widget tests (#7148)
3890cee 
This PR introduces a tolerance for rfw material widget tests to fix the golden test error in flutter/flutter#151611.

Part of a fix for flutter/flutter#151659.
victoreronmosele added a commit to victoreronmosele/tests that referenced this issue Oct 11, 2024
@victoreronmosele
Re-enable rfw tests
dc201c0 
For flutter/flutter#151659. 
Fix in flutter/packages#7148.
@victoreronmosele victoreronmosele linked a pull request Oct 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: disabled test Tracks the restoration of a disabled test p: rfw Remote Flutter Widgets package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable rfw tests victoreronmosele/tests
3 participants
@stuartmorgan @zanderso @danagbemava-nc