Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] update to support NavigationRail #13

Open
daadu opened this issue May 16, 2020 · 4 comments
Open

[FeatureRequest] update to support NavigationRail #13

daadu opened this issue May 16, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@daadu
Copy link
Member

daadu commented May 16, 2020

Flutter 1.17 comes with NavigationRail component which is part of material design guideline. It suggest adapting BottomNavigationBar [mobile] -> NavigationRail [tablet] -> NavigationDrawer [desktop]. Check image below:

ezgif com-video-to-gif

@rodydavis
Copy link
Member

This package is my replacement: https://pub.dev/packages/navigation_rail

@rodydavis rodydavis added the enhancement New feature or request label May 26, 2020
@rodydavis rodydavis self-assigned this May 26, 2020
@daadu
Copy link
Member Author

daadu commented May 27, 2020

I think this should be adapted with this package it self following material design guidelines. If there is a BottomBar defined then It should be replaces with NavigationRail in larger screen (check animation).

@rodydavis
Copy link
Member

It is my package I created too, but I agree. I can have this adapt it as well. This package was made before the rail was added to the spec. Responsive scaffold is a drop in scaffold replacement whereas navigation rail is a new layout widget similar I
in feature set.

@Leptopoda
Copy link

Hi @rodydavis
I need this functionality and am starting work on it.
How would you like this feature to be implemented?
Just wrapping the responsive_scaffold in a NavRail does not seem to be the way to go.
How should the tablet view be handled (Currently the AppBar/titlebar continues over the nav rail when in tablet mode, see the picture).
Should the NavigationRail be integrated into the master view? Should we just drop the appbar of the master and detail and show the unified one?.
Also The Master view supports usage of Slivers so how should they be handled?
Screenshot_20210520_113116

I'm deprecating my own NavRail and if I already do the work I'd like to contribute it back to the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants