-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional selectorLabels are not added to primary deployment #1312
Comments
I noticed one more thing - after unsuccessful promotion deployment rolled back, then after 5-10 seconds I see 'New revision detected' again and flagger tries to promote failed deployment second time. |
@aryan9600 could you help please? I looked at #1227 and still do not know how to resolve this. |
I left just 'app.kubernetes.io/instance' as single selector label, now all services have this label as a selector, so I do everything correctly. But if I specify more than one label - rest labels except first in a row are not considered by flagger. |
Regarding deployment selector labels - they are changing only if you delete and then install helm release, so flagger operator doesn't modify primary deployment selector labels on the fly (works with service selector label). |
I'm observing the same issue. We are running flagger 1.27 In the helm chart I've set following values: On the initial deployment we have following labels:
On the primary deployment, not all template labels are updated. This is causing that affinity and topology spread constrain rules do not work at all due mismatch in labels.
From my tests only the first label match in |
Thats exactly what the code does https://github.com/fluxcd/flagger/blob/main/pkg/canary/daemonset_controller.go#L314 This completely breaks the deployment for us :( |
Hey @aryan9600, any comments on this? You see that users face this issue having an impact from small to high? Almost 1 year after issue is created and no feedback at all. |
P.S.: recently we updated flagger to latest, issue still persists. |
Bumping this thread. Just ran into this problem while trying to implement safe deployments for an event-driven application using Dapr. Without getting into too many details, Dapr creates a This is a total blocker for me :( |
Describe the bug
I tried to use selectorLabels described there, but my additional selector labels are present only on original deployment {deploy} and not on primary {deploy}-primary created by flagger.
original deployment:
primary deployment
flagger values.yaml
flagger container spec
P.S.: I'm using helm chart for this deployment
To Reproduce
Expected behavior
All labels that specified to at 'selectorLabels' are copied to primary from original deployment after successful promotion
Additional context
The text was updated successfully, but these errors were encountered: