Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in Istio 1.5 headers regex #501

Closed
stefanprodan opened this issue Mar 14, 2020 · 1 comment
Closed

Breaking change in Istio 1.5 headers regex #501

stefanprodan opened this issue Mar 14, 2020 · 1 comment
Labels
kind/upstream-bug wontfix This will not be worked on

Comments

@stefanprodan
Copy link
Member

stefanprodan commented Mar 14, 2020

Istio 1.5 doesn't allow negative lookahead regex.

With Istio 1.4 it was possible to target a specific browser e.g.:

match:
  - headers:
      user-agent:
        regex: "^(?!.*(?:Chrome|Edge)).*Safari.*"

Such a configuration doesn't work with Istio 1.5, the gateway rejects it:

RouteConfiguration rejected: invalid perl operator: (?!

Upgrading from Istio 1.4 to Istio 1.5 will result in downtime if you are using negative lookahead regex in virtual services.

@stefanprodan
Copy link
Member Author

Long story short: Envoy has switched to Google's re2
regex engine in envoyproxy/envoy#7878 and re2 does not support before/after text not matching https://github.com/google/re2/wiki/Syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/upstream-bug wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant