Support for New Relic Metrics Provider

[shankarb-airwallex]

Question
So i see that the current list of metric providers include Prometheus, Datadog and Cloudwatch. Is there a plan to add New Relic to that list? This is perhaps the only thing that is holding us back from using Flagger across the board.

Is there a plan to add support down the line?

[stefanprodan]

I've never used New Relic but I'm open to reviewing a PR for this. Doing a quick Google search for NRQL go-client nothing come up so I don't know how would someone implement it.

[shankarb-airwallex]

I did find something. https://github.com/newrelic/newrelic-client-go

[stefanprodan]

This looks ok to me https://github.com/newrelic/newrelic-client-go/blob/master/pkg/nrdb/example_query_test.go so it should be doable if a New Relic user wants to add this feature to Flagger.

[shankarb-airwallex]

Sure, we are still in an evaluation phase with flagger within the organisation and if we are given the go-ahead to use Flagger then we will work on adding it. Thank you very much!

[bernardoVale]

@stefanprodan can you give me some tips of how this can be done? I'm willing to implement this feature. We use NR a lot, especially NewRelic Insights.

[stefanprodan]

@bernardoVale the NewRelic implementation should be similar to Datadog, please see https://github.com/weaveworks/flagger/blob/master/pkg/metrics/providers/datadog.go

[fpetkovski]

A have added New Relic as a metrics provider in the following pull request: #691

I still have to do manual testing but I wanted to get some initial feedback on whether the work is headed in the right direction. Thanks!

[stefanprodan]

Implemented in #691