Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for session affinity for Gloo canaries #707

Closed
paritadhandha opened this issue Oct 7, 2020 · 2 comments · Fixed by #765
Closed

Add support for session affinity for Gloo canaries #707

paritadhandha opened this issue Oct 7, 2020 · 2 comments · Fixed by #765
Labels
kind/feature Feature request kind/upstream-blocked Depends on a missing upstream feature

Comments

@paritadhandha
Copy link

We use flagger canaries with gloo with following version configurations.

Flagger version: 1.0.1/1.0.0
Kubernetes version: v1.15
Flagger-loadtester: 0.18.0
Flagger CRD version: Version: v1beta1
Config: canary with glooEnterprise (v1.4.6)

We wanted to enable session affinity for our canary deployments and found this documentation:
https://docs.flagger.app/usage/deployment-strategies#a-b-testing

There are examples for enabling session affinity for Istio, NGINX, Contour and App Mesh but there was no mention for session affinity with Gloo.

Is there any intention of adding support for session affinity with gloo?

Thank you!

@stefanprodan
Copy link
Member

stefanprodan commented Oct 7, 2020

Flagger uses the Gloo UpstreamGroup API for traffic manipulation. It doesn't look like this API allows setting HTTP headers or cookies required to implement session affinity.

@stefanprodan stefanprodan added kind/feature Feature request kind/upstream-blocked Depends on a missing upstream feature labels Oct 7, 2020
@mikesouza
Copy link

mikesouza commented Oct 7, 2020

Flagger uses the Gloo UpstreamGroup API for traffic manipulation. It doesn't look like this API allows setting HTTP headers or cookies required to implement session affinity.

@stefanprodan Thank you for clarifying that the issue is upstream with a lack of support in Gloo. We will ask solo.io/ Gloo and see if support can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request kind/upstream-blocked Depends on a missing upstream feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants