Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RecoverPanic option on reconcilers #2952

Closed
6 tasks done
hiddeco opened this issue Aug 2, 2022 · 5 comments
Closed
6 tasks done

Enable RecoverPanic option on reconcilers #2952

hiddeco opened this issue Aug 2, 2022 · 5 comments
Assignees
@Santosh1176
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Security

Comments

@hiddeco
Copy link
Member

hiddeco commented Aug 2, 2022 •
edited by pjbgf
Loading

Controller-runtime has a setting which can be set on a reconciler to ensure it recovers from panics instead of making the whole controller crash. This should be enabled on all reconcilers to improve continuity, which is especially useful for e.g. source-controller where a restart often means an erase of the cache.

  • source-controller
  • kustomize-controller
  • helm-controller
  • notification-controller
  • image-reflector-controller
  • image-automation-controller
@hiddeco hiddeco added enhancement New feature or request good first issue Good for newcomers labels Aug 2, 2022
@Santosh1176
Copy link
Contributor

Santosh1176 commented Aug 4, 2022 •
edited
Loading

Hey @hiddeco can I work on this?
Just to clarify, all the reconcilers in the above listed controllers(repos) need to be enabled with RecoverPanic option?

@stefanprodan
Copy link
Member

Just to clarify, all the reconcilers in the above listed controllers(repos) need to be enabled with RecoverPanic option?

Yes

@Santosh1176
Copy link
Contributor

Please /assign

@Santosh1176 Santosh1176 mentioned this issue Aug 9, 2022
Merged
@stefanprodan stefanprodan mentioned this issue Aug 10, 2022
Merged
@pjbgf pjbgf added this to the GA milestone Aug 11, 2022
This was referenced Aug 12, 2022
Merged
Merged
Merged
Merged
@pjbgf
Copy link
Member

pjbgf commented Aug 15, 2022

@Santosh1176 thanks for working through all controllers to get this implemented. 🙇

@pjbgf pjbgf closed this as completed Aug 15, 2022
@Santosh1176
Copy link
Contributor

@Santosh1176 thanks for working through all controllers to get this implemented. bow

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Santosh1176 Santosh1176

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Security
Development

No branches or pull requests
4 participants
@stefanprodan @pjbgf @hiddeco @Santosh1176