Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the order of status conditions #617

Closed
darkowlzz opened this issue Mar 16, 2022 · 0 comments · Fixed by #646
Closed

Test the order of status conditions #617

darkowlzz opened this issue Mar 16, 2022 · 0 comments · Fixed by #646
Labels
good first issue Good for newcomers

Comments

@darkowlzz
Copy link
Contributor

darkowlzz commented Mar 16, 2022 •
edited
Loading

All the reconcilers have their own set of status conditions with priorities which are considered while summarizing the status conditions.
There's no test at the moment to ensure that we don't break the order of the status conditions unintentionally.

The tests for this would to run SummarizeAndPatch() with different combinations of status conditions for each of the reconcilers using their set of ReadyConditions.

Refer #613 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate positive polarity conditions for ArtifactInStorage fluxcd/source-controller
1 participant
@darkowlzz