Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspended sources can't be deleted #934

Closed
stefanprodan opened this issue Oct 17, 2022 · 0 comments · Fixed by #937
Closed

Suspended sources can't be deleted #934

stefanprodan opened this issue Oct 17, 2022 · 0 comments · Fixed by #937
Assignees
@darkowlzz
Labels
bug Something isn't working
Milestone
Helm GA

Comments

@stefanprodan
Copy link
Member

Once a source is suspended, the controller no longer removes the finalizer nor does it clear the storage, making impossible to delete suspended sources as they will hang forever.
@stefanprodan stefanprodan added the bug Something isn't working label Oct 17, 2022
@stefanprodan stefanprodan added this to the GA milestone Oct 17, 2022
@darkowlzz darkowlzz mentioned this issue Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkowlzz darkowlzz

Labels
bug Something isn't working
Projects
Maintainers' Focus
Status: Done
Milestone
Helm GA
Development

Successfully merging a pull request may close this issue.

Allow deleting suspended objects fluxcd/source-controller
2 participants
@darkowlzz @stefanprodan