Use patch instead of update when adding finalizers #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to prevent source-controller from managing all the fields under `.spec`. Signed-off-by: Stefan Prodan <[email protected]>
hiddeco
approved these changes
Jan 13, 2022
kingdonb
pushed a commit
to kingdonb/bootstrap-repo
that referenced
this pull request
Jan 20, 2022
This reverts commit 0c9c448. On second thought we do want this fix: fluxcd/source-controller#542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to prevent source-controller from managing all the fields under
.spec.Ref: fluxcd/flux2#2286