-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support the sum of negative numbers #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivelazco
requested review from
a team,
crash7,
gaston-flores and
peibol85
and removed request for
a team
June 12, 2020 17:59
crash7
changed the title
fix: support the sum of negative numbers BREAKING CHANGE
fix: support the sum of negative numbers
Jun 12, 2020
@nvelazco could you add a test for this? Thanks! |
ivelazco
force-pushed
the
fix/sum-negative-props
branch
from
June 17, 2020 14:07
33c8fd8
to
4f78f8b
Compare
➿ Code coverage
|
crash7
approved these changes
Jun 19, 2020
flybondi-nelson
added a commit
that referenced
this pull request
Jun 19, 2020
# [4.0.0](v3.6.0...v4.0.0) (2020-06-19) ### Bug Fixes * support the sum of negative numbers ([#11](#11)) ([9ab73d9](9ab73d9)) ### BREAKING CHANGES * sum negative numbers * fix: support the sum of negative numbers * test: add test for mixed amounts
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: support the sum of negative numbers