Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support the sum of negative numbers #11

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Conversation

ivelazco
Copy link
Contributor

@ivelazco ivelazco commented Jun 12, 2020

BREAKING CHANGE: support the sum of negative numbers

@ivelazco ivelazco requested a review from nfantone as a code owner June 12, 2020 17:59
@ivelazco ivelazco requested review from a team, crash7, gaston-flores and peibol85 and removed request for a team June 12, 2020 17:59
@crash7 crash7 changed the title fix: support the sum of negative numbers BREAKING CHANGE fix: support the sum of negative numbers Jun 12, 2020
@crash7
Copy link
Contributor

crash7 commented Jun 12, 2020

@nvelazco could you add a test for this? Thanks!

@github-actions
Copy link

Code coverage

Filename Statements Branches Functions Lines
src/number-prop.js 100% 100% 100% 100%
src/cast-array.js 100% 100% 100% 100%
src/curry-n.js 100% 100% 100% 100%
src/utils/_arity.js 100% 100% 100% 100%
src/utils/_curry1.js 100% 100% 100% 100%
src/utils/is-placeholder.js 100% 100% 100% 100%
src/utils/copy-name.js 100% 100% 100% 100%
src/utils/_curry2.js 75% 53.85% 60% 75%
src/utils/_curry-n.js 100% 100% 100% 100%
src/curry.js 100% 100% 100% 100%
src/array-path.js 100% 100% 100% 100%
src/compact.js 100% 100% 100% 100%
src/is-nil-empty.js 100% 100% 100% 100%
src/array-prop.js 100% 100% 100% 100%
src/reject-nil.js 100% 100% 100% 100%
src/merge-into.js 100% 100% 100% 100%
src/sum-prop.js 100% 100% 100% 100%
src/round.js 100% 100% 100% 100%
src/utils/_math-constants.js 100% 100% 100% 100%
src/truncate.js 100% 100% 100% 100%
src/all-to-lower-upper.js 100% 100% 100% 100%
src/not-equals.js 100% 100% 100% 100%
src/interpolate.js 100% 100% 100% 100%
src/utils/escape-regex.js 100% 100% 100% 100%
src/apply-spec.js 100% 100% 100% 100%
src/merge-spec.js 100% 100% 100% 100%
src/is-one-of.js 100% 100% 100% 100%
src/compact-spec.js 100% 100% 100% 100%
src/coalesce.js 100% 100% 100% 100%
src/prop-of.js 100% 100% 100% 100%
src/join-from.js 100% 100% 100% 100%
src/lower-path-satisfies.js 100% 100% 100% 100%
src/utils/_curry3.js 38.1% 32.43% 16.67% 38.1%
src/lower-path.js 100% 100% 100% 100%
src/boolean-prop.js 100% 50% 100% 100%
src/lower-equals.js 100% 100% 100% 100%
src/lower-trim.js 100% 100% 100% 100%
src/capitalize-words.js 100% 100% 100% 100%
src/capitalize.js 100% 100% 100% 100%
src/spread-prop.js 100% 100% 100% 100%
src/rename-keys.js 100% 100% 100% 100%
src/throw-error.js 100% 100% 100% 100%
src/map-keys.js 100% 100% 100% 100%
src/always-new.js 100% 100% 100% 100%

@crash7 crash7 merged commit 9ab73d9 into master Jun 19, 2020
@crash7 crash7 deleted the fix/sum-negative-props branch June 19, 2020 18:49
flybondi-nelson added a commit that referenced this pull request Jun 19, 2020
# [4.0.0](v3.6.0...v4.0.0) (2020-06-19)

### Bug Fixes

* support the sum of negative numbers ([#11](#11)) ([9ab73d9](9ab73d9))

### BREAKING CHANGES

* sum negative numbers

* fix: support the sum of negative numbers

* test: add test for mixed amounts
@flybondi-nelson
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants