Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is not one of #145

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: add is not one of #145

merged 2 commits into from
Oct 30, 2023

Conversation

gleguizamon
Copy link
Member

@gleguizamon gleguizamon commented Oct 10, 2023

@crash7 I'm not sure about the examples, but I think they can be improved.

PD: this complement made in collab with @garaycarlosalfredo

@gleguizamon gleguizamon self-assigned this Oct 10, 2023
@gleguizamon gleguizamon marked this pull request as ready for review October 10, 2023 21:42
@gleguizamon gleguizamon requested review from nfantone and a team as code owners October 10, 2023 21:42
@gleguizamon gleguizamon requested review from martin-i-silva, lubermudezz and francosamilian and removed request for a team October 10, 2023 21:42
Copy link
Member Author

@gleguizamon gleguizamon Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: here the imports were re-ordered alphabetically by file, and the import of isOneOf was changed to a named import for keep both functions in the same file.

Copy link
Contributor

@crash7 crash7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crash7 crash7 enabled auto-merge (squash) October 30, 2023 17:44
@crash7 crash7 merged commit d34dc0e into master Oct 30, 2023
3 checks passed
@crash7 crash7 deleted the feat/add-is-not-one-of branch October 30, 2023 17:44
flybondi-nelson added a commit that referenced this pull request Oct 30, 2023
# [5.1.0](v5.0.1...v5.1.0) (2023-10-30)

### Features

* add is not one of ([#145](#145)) ([d34dc0e](d34dc0e))
@flybondi-nelson
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants