From 68742e1d8756dd0a51585cff0d7da2034e05a4ca Mon Sep 17 00:00:00 2001 From: refnum <68672+refnum@users.noreply.github.com> Date: Wed, 4 Mar 2020 14:48:41 +0000 Subject: [PATCH] Fix clang -Wsign-conversion warning in grisu_count_digits. (#1573) grisu_count_digits is only used by grisu_gen_digits, which assigns the unsigned result to a (signed) int. Although grisu_count_digits always returns a positive integer this keeps its return type in sync with the type its result is assigned to. --- include/fmt/format-inl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fmt/format-inl.h b/include/fmt/format-inl.h index 4ad4df4cb6be..0872fcbbfe59 100644 --- a/include/fmt/format-inl.h +++ b/include/fmt/format-inl.h @@ -756,7 +756,7 @@ enum result { } // A version of count_digits optimized for grisu_gen_digits. -inline unsigned grisu_count_digits(uint32_t n) { +inline int grisu_count_digits(uint32_t n) { if (n < 10) return 1; if (n < 100) return 2; if (n < 1000) return 3;