Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined reference fmt::v5::format_error::~format_error() when building dll #1205

Closed
HazardyKnusperkeks opened this issue Jun 23, 2019 · 2 comments · Fixed by #1206
Closed

Comments

@HazardyKnusperkeks
Copy link
Contributor

Hi, same setup as in #1204.

I get multiple

<file>: (.text+0x2c): undefined reference to `fmt::v5::format_error::~format_error()'

The destructor was added in commit 1c3197b defined in format-inl.h, but in I only #include <fmt/format.h>. I think it should be added there, or the class has to be exported.

@vitaut
Copy link
Contributor

vitaut commented Jun 23, 2019

The destructor should be marked with FMT_API. Could you submit a PR?

@HazardyKnusperkeks
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants