Clang warnings Wsign-conversion

[DaanDeMeyer]

_deps/fmt-src/include/fmt/format.h:1566:45: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
    size_t size() const { return num_digits + 2; }

_deps/fmt-src/include/fmt/format.h:1588:28: warning: implicit conversion changes signedness: 'const int' to 'unsigned int' [-Wsign-conversion]
    unsigned width = specs.width;  // User-perceived width (in code points).

_deps/fmt-src/include/fmt/format.h:1317:22: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        size = specs.width;

_deps/fmt-src/include/fmt/format.h:1316:25: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
        padding = specs.width - size;

Started appearing after include fmt/ostream.h

[vitaut]

Thanks for reporting. Which compiler version are you using?

[DaanDeMeyer]

Clang 8.0.0 (Arch Linux)

[vitaut]

Also could you provide an example that reproduces the warning?

[DaanDeMeyer]

_deps/fmt-src/include/fmt/format.h:1689:46: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    if (!specs) return pw(reserve(num_digits + 2));

I forgot to include this one as well.

[DaanDeMeyer]

https://github.com/DaanDeMeyer/fmt-warning-reproduce

This repo should reproduce the warnings (GCC 9.1.0 triggers them as well).

[vitaut]

Should be fixed now.