Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that support for arbitrary number of arguments doesn't increase compiled code size #143

Closed
vitaut opened this issue Mar 24, 2015 · 3 comments · Fixed by #149
Closed

Make sure that support for arbitrary number of arguments doesn't increase compiled code size #143

vitaut opened this issue Mar 24, 2015 · 3 comments · Fixed by #149

Comments

@vitaut
Copy link
Contributor

vitaut commented Mar 24, 2015

Compiled code size has been reduced in cf04d98, but need to check that there is no regression compared to version 1.1.0.
@vitaut
Copy link
Contributor Author

vitaut commented Mar 25, 2015

Target: 34912
Current: 47200
Partially caused by zero initialization of extra argument. Can be easily bypassed when the number of arguments is less than MAX_PACKED_ARGS.

@vitaut
Copy link
Contributor Author

vitaut commented Mar 25, 2015

After 2ba3988: 39008

@vitaut
Copy link
Contributor Author

vitaut commented Mar 26, 2015

So the remaining difference is only due to increase in allocated stack size:

screenshot from 2015-03-25 21 53 46

which can be fixed by using a union of (Value*, Arg*).

@vitaut vitaut mentioned this issue Apr 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compact arglist fmtlib/fmt
1 participant
@vitaut