Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings (-Wsign-conversion) under Clang #1604

Closed
Karsten1987 opened this issue Mar 24, 2020 · 1 comment
Closed

Build warnings (-Wsign-conversion) under Clang #1604

Karsten1987 opened this issue Mar 24, 2020 · 1 comment

Comments

@Karsten1987
Copy link

Originally reported in here: ros2/spdlog_vendor#4

There is a quite a few warnings under clang which ideally should be addressed. Pretty much all in the style of converting int to size_t:

In file included from /opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:10:
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:484:48: warning: implicit conversion changes signedness: 'int' to 'unsigned long long' [-Wsign-conversion]
          (min_exponent + fp::significand_size - 1) * one_over_log2_10 +`
@vitaut
Copy link
Contributor

vitaut commented Mar 25, 2020

Fixed in 96c68af.

@vitaut vitaut closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants