Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate changes by Alf Steinbach #171

Closed
vitaut opened this issue Jun 9, 2015 · 4 comments
Closed

Integrate changes by Alf Steinbach #171

vitaut opened this issue Jun 9, 2015 · 4 comments

Comments

@vitaut
Copy link
Contributor

vitaut commented Jun 9, 2015

https://gist.github.com/alfps/6ee84b819f63afcf0524

  1. Replaced _WIN32 with FMT_ADD_EXTRA_WINDOWS_SUPPORT where appropriate.
  2. Placed the anonymous namespace within fmt namespace (for header-only use).
  3. Moved template out of anonymous namespace (for correctness).
  4. Defaulted fmt::ignore_incompatible_str, but this scheme needs fixing.
  5. Added fmt::UnderlyingType in header.
  6. Fixed "char Fill = static_cast..." in format::internal::ArgFormatter::visit_char
  7. Fixed "*out = static_cast..." in format::internal::ArgFormatter::visit_char
  8. Fixed "char Fill = static_cast..." in BasicWriter::fill_padding
  9. Fixed "char Fill = static_cast..." in BasicWriter::write_double
  10. Fixed "char Fill = static_cast..." in BasicWriter::prepare_int_buffer
  11. Fixed "char Fill = static_cast..." in BasicWriter::write_str
@vitaut
Copy link
Contributor Author

vitaut commented Jun 12, 2015

[1] is done in 24c309f.

@vitaut
Copy link
Contributor Author

vitaut commented Jun 12, 2015

[2] is done in 8725d07.
[3] is not needed AFAICS.

@vitaut
Copy link
Contributor Author

vitaut commented Jun 16, 2015

[4] is done in 270069b.

@vitaut
Copy link
Contributor Author

vitaut commented Jun 17, 2015

[5] - [11] are done in 147e5eb via CharTraits.

@vitaut vitaut closed this as completed Jun 17, 2015
@wrowe wrowe mentioned this issue Nov 4, 2019
Merged
@dalboris dalboris mentioned this issue Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitaut