Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang Warnings (with -W -Wall -Werror) #175

Closed
cubicool opened this issue Jun 14, 2015 · 1 comment
Closed

Clang Warnings (with -W -Wall -Werror) #175

cubicool opened this issue Jun 14, 2015 · 1 comment

Comments

@cubicool
Copy link

The no-op, internal strerror_r ends up being unused when compiling with Clang on Linux with all error-reporting and pedantacism enabled. The following error is generated:

cppformat/format.cc:98:37: error: unused function 'strerror_r' [-Werror,-Wunused-function]
static inline fmt::internal::None<> strerror_r(int, char *, ...) {
                                ^
1 error generated.

I found the following link that helps explain the situation somewhat: http://zverovich.net/2015/03/13/reliable-detection-of-strerror-variants.html

For now I'm simply adding -Wno-unused-function, but seeing as I use cppformat like a fiend, it'd be nice to have it fixed in the source. I will submit a PR if desired.

@vitaut
Copy link
Contributor

vitaut commented Jun 14, 2015

Fixed in 63f6c10. Thanks!

@vitaut vitaut closed this as completed Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants