Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt.cc includes os.cc regardless of the FMT_OS option. #3777

Closed
gabime opened this issue Dec 30, 2023 · 6 comments
Closed

fmt.cc includes os.cc regardless of the FMT_OS option. #3777

gabime opened this issue Dec 30, 2023 · 6 comments

Comments

@gabime
Copy link
Contributor

gabime commented Dec 30, 2023

I think it should avoid it if FMT_OS is set to OFF.
@vitaut
Copy link
Contributor

vitaut commented Dec 30, 2023

Makes sense in general but is there any concrete problem you are trying to solve?

@gabime
Copy link
Contributor Author

gabime commented Dec 30, 2023

In spdlog ver 2.x fmt is fetched and compiled as a dependency. Since spdlog doesn’t require the os features of fmt it sets FMT_OS to OFF.

@vitaut
Copy link
Contributor

vitaut commented Jan 1, 2024

Should be fixed in 398ddb8.

@vitaut vitaut closed this as completed Jan 1, 2024
@gabime
Copy link
Contributor Author

gabime commented Jan 1, 2024

Thanks. However it still includes “os.cc” unconditionally here.

@vitaut vitaut reopened this Jan 1, 2024
@vitaut
Copy link
Contributor

vitaut commented Jan 2, 2024

Take 2: 9659f22.

@vitaut vitaut closed this as completed Jan 2, 2024
@phprus phprus mentioned this issue Jan 2, 2024
Merged
@vitaut
Copy link
Contributor

vitaut commented Jan 2, 2024

Take 3: #3783. Thanks to @phprus.

@BrewTestBot BrewTestBot mentioned this issue Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @gabime