Does not build on OpenBSD

[brad0]

Looking at updating our fmt port from 8.1.1 to 10.2.1 and noticed it no longer builds..

FAILED: test/CMakeFiles/posix-mock-test.dir/posix-mock-test.cc.o
/home/ports/pobj/fmt-10.2.1/bin/c++ -DGTEST_HAS_STD_WSTRING=1 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING=1 -I/home/ports/pobj/fmt-10.2.1/fmt-10.2.1/include -isystem /home/ports/pobj/fmt-10.2.1/fmt-10.2.1/test/gtest/. -O2 -pipe -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT test/CMakeFiles/posix-mock-test.dir/posix-mock-test.cc.o -MF test/CMakeFiles/posix-mock-test.dir/posix-mock-test.cc.o.d -o test/CMakeFiles/posix-mock-test.dir/posix-mock-test.cc.o -c /home/ports/pobj/fmt-10.2.1/fmt-10.2.1/test/posix-mock-test.cc
In file included from /home/ports/pobj/fmt-10.2.1/fmt-10.2.1/test/posix-mock-test.cc:21:
/home/ports/pobj/fmt-10.2.1/fmt-10.2.1/test/../src/os.cc:190:23: error: expected unqualified-id
  int fd = FMT_SYSTEM(fileno FMT_DISABLE_MACRO(file_));
                      ^
1 error generated.

[brad0]

Reverting 6b0082e and it now builds Ok.

[brad0]

Ping.

[vitaut]

How is fileno defined on your system?

[mwinterb]

The macro used in OpenBSD and FreeBSD is defined like this:

#define fileno(p) (!__isthreaded ? __sfileno(p) : (fileno)(p))

https://gcc.godbolt.org/z/6TEqqn8rT

[vitaut]

Thanks for the repro, @mwinterb. Tentative fix: 8ecb77f. @brad0, could you confirm that it works?

[brad0]

This now builds with the diff applied. Thanks.

[vitaut]

Thanks for confirming that the fix works. It is merged now.