Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASCII color escape code numbers #968

Closed
Rakete1111 opened this issue Dec 6, 2018 · 1 comment · Fixed by #974
Closed

Support ASCII color escape code numbers #968

Rakete1111 opened this issue Dec 6, 2018 · 1 comment · Fixed by #974

Comments

@Rakete1111
Copy link
Contributor

Rakete1111 commented Dec 6, 2018

We currently support a wide range of colors, but the "default" ones from the terminal aren't really there.

I think it would be a good idea to support them, because (now correct me if I'm wrong) that the colors can change slightly depending on the pallete of the terminal. Hard coding the rgb doesn't always look nice and so that the colors are more readable I'd suggest that we add another color mode with only those colors supported.

What do you think?

Note: I just realized that this is what the old color printing does. :)

@vitaut
Copy link
Contributor

vitaut commented Dec 9, 2018

Are you talking about these: https://en.wikipedia.org/wiki/ANSI_escape_code#3/4_bit ? I think it would be nice to support them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants