Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compile error, and fix #941

Closed
lgritz opened this issue Nov 23, 2018 · 2 comments
Closed

Windows compile error, and fix #941

lgritz opened this issue Nov 23, 2018 · 2 comments

Comments

@lgritz
Copy link

lgritz commented Nov 23, 2018

In the current master, format.h:312,

if (const_check(sizeof(isinf(x)) != sizeof(dummy_int)))

I'm seeing an error about ambiguous use of dummy_int on Windows (MSVS 14.0, I think).
I believe that the fix is just to change it to fmt::internal::dummy_int, as it is a few lines later.

I'm very sorry about reporting it like this rather than submitting a PR. I maintain large open source projects myself and it drives me crazy when people do this. But the fact is that I work in a large company where it's a considerable hassle to get legal approval to contribute a PR containing actual code to a project that hasn't already been vetted. It would take me weeks, especially over the holiday season. Sorry again.

vitaut added a commit that referenced this issue Nov 24, 2018
@vitaut
Copy link
Contributor

vitaut commented Nov 24, 2018

Committed a tentative fix in 01640f4. Let me know if it resolves the problem and thanks for reporting!

@lgritz
Copy link
Author

lgritz commented Nov 24, 2018

Yes, works! Thanks.

@lgritz lgritz closed this as completed Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants