make notify calls explicit #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnichol
added a commit
that referenced
this pull request
May 22, 2013
Use old-form notifies to support AWS OpsWorks.
fnichol
added a commit
that referenced
this pull request
May 22, 2013
|
Looks good to me, thank you!! |
|
thanks. they are using chef v9, so there will be oddities here an there. I want an upgrade now. In the meanwhile, you're doing the world a favor. Thanks. |
|
Well thank you for doing the hard work tracking this down |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Chef that AWS's OpsWorks employs does not handle the
notifiescalls with implicit resource shortcuts. This issue is outlined here.Accepting this pull request will not materially change the makeup of the cookbook and will ease the bleeding-edge users of AWS OpsWorks. Ultimately, OpsWorks will upgrade Chef and this will be a non-issue. But, until then, this pull request will help myself and others.