Skip to content
This repository has been archived by the owner on Jul 6, 2024. It is now read-only.

feature: use lua-language-server's builtin luv meta library #127

Closed
1 task done
T-727 opened this issue Feb 13, 2023 · 1 comment · Fixed by #128
Closed
1 task done

feature: use lua-language-server's builtin luv meta library #127

T-727 opened this issue Feb 13, 2023 · 1 comment · Fixed by #128
Labels
enhancement New feature or request

Comments

@T-727
Copy link
Contributor

T-727 commented Feb 13, 2023

Did you check the docs?

  • I have read all the neodev.nvim docs

Is your feature request related to a problem? Please describe.

Hey!
So I've noticed that luv has been added to lua-language-server's builtin meta libraries since 3 months ago..
And so it would be nice to simply replace the luv metadata from neodev with lua-language-server's and have much more complete luv information :)

Describe the solution you'd like

  • Add "${3rd}/luv/library" to workspace.library
  • Annotate vim.loop with @type uv

Describe alternatives you've considered

Stay as is.

Additional context

According to this test:
https://github.com/neovim/neovim/tree/master/test/functional/lua/loop_spec.lua#L154
vim.loop isn't modified from luv so there shouldn't be any clashes.

Potential caveat

If a user updates their lua-language-server version but not Neovim, there could be a slight desync in information.

@T-727 T-727 added the enhancement New feature or request label Feb 13, 2023
@folke folke closed this as completed in 8c32d8b Feb 13, 2023
@folke
Copy link
Owner

folke commented Feb 13, 2023

Awesome, didn't know that!

Just updated the code. Types will be re-generated in a bit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants