-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to ensure a glyphs source file conforms to the file format schema #3048
Comments
is it an opportunity to bootstrap a |
@schriftgestalt, this reminds me of a conversation I had with @mekkablue last year in São Paulo, Brazil, in which he expressed interest in having FontBakery embedded into GlyphsApp to run checks automatically as designers work on their fonts. We could create a |
@schriftgestalt, do you have runtime GlyphsApp quality checks that you'd be happy if we ported into FontBakery? |
I don’t have interesting test. Just a few basic sanity test. I’ll see if I find something. Adding more test was always on my list. |
We now can run checks agains glyphs source files in fontbakery. An initial implementation for this check might be straightforward: does the file parse without errors when loading it with GlyphsLib? |
There is a validator in https://github.com/schriftgestalt/GlyphsSDK/tree/Glyphs3/GlyphsFileFormat/validator That might be useful. |
What's the rationale for this? Because if Glyphs (or even glyphsLib) is authoring files that don't conform to its own schema, that isn't something that the designer can fix. |
It might be useful to cast a wider net to catch a) problems with Glyphs/glyphsLib or b) to find issues with schemes. It would be better put into the respective unit test but here it gets more exposure. |
googlefonts/glyphsLib#332 (comment)
The text was updated successfully, but these errors were encountered: