Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to ensure a glyphs source file conforms to the file format schema #3048

Open
felipesanches opened this issue Sep 29, 2020 · 8 comments
Assignees
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id

Comments

@felipesanches
Copy link
Collaborator

googlefonts/glyphsLib#332 (comment)

@felipesanches felipesanches self-assigned this Sep 29, 2020
@felipesanches
Copy link
Collaborator Author

is it an opportunity to bootstrap a check-glyphsapp profile with source-level checks for Glyphs project files?

@felipesanches felipesanches changed the title Add check to ensure a glyphs source file conforms to the file format shcema Add check to ensure a glyphs source file conforms to the file format schema Sep 29, 2020
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Sep 29, 2020
@felipesanches
Copy link
Collaborator Author

felipesanches commented Sep 29, 2020

@schriftgestalt, this reminds me of a conversation I had with @mekkablue last year in São Paulo, Brazil, in which he expressed interest in having FontBakery embedded into GlyphsApp to run checks automatically as designers work on their fonts.

We could create a glyphsapp profile that would be enabled by default and then let users tweak settings if they want to enable other check profiles as well.

@felipesanches
Copy link
Collaborator Author

@schriftgestalt, do you have runtime GlyphsApp quality checks that you'd be happy if we ported into FontBakery?

@schriftgestalt
Copy link

I don’t have interesting test. Just a few basic sanity test. I’ll see if I find something.

Adding more test was always on my list.

@felipesanches
Copy link
Collaborator Author

We now can run checks agains glyphs source files in fontbakery.

An initial implementation for this check might be straightforward: does the file parse without errors when loading it with GlyphsLib?

@felipesanches felipesanches added this to the 0.8.5 milestone Dec 9, 2021
@schriftgestalt
Copy link

There is a validator in https://github.com/schriftgestalt/GlyphsSDK/tree/Glyphs3/GlyphsFileFormat/validator That might be useful.

@felipesanches felipesanches modified the milestones: 0.8.5, 0.8.12 Dec 15, 2021
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.13 Aug 19, 2022
@felipesanches felipesanches modified the milestones: 0.8.13, 0.8.14 Jun 2, 2023
@simoncozens
Copy link
Collaborator

What's the rationale for this? Because if Glyphs (or even glyphsLib) is authoring files that don't conform to its own schema, that isn't something that the designer can fix.

@schriftgestalt
Copy link

It might be useful to cast a wider net to catch a) problems with Glyphs/glyphsLib or b) to find issues with schemes. It would be better put into the respective unit test but here it gets more exposure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Development

No branches or pull requests

3 participants