Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop test code for narrow builds of Python #61

Closed
SnoopJ opened this issue Sep 20, 2023 · 0 comments
Closed

Drop test code for narrow builds of Python #61

SnoopJ opened this issue Sep 20, 2023 · 0 comments

Comments

@SnoopJ
Copy link
Collaborator

SnoopJ commented Sep 20, 2023

There is some code in the unicodedata2 test associated with narrow (UCS2-only) builds of Python. I believe this code was added (in #35) when unicodedata2 was still supporting Python 2 and versions before Python 3.3 when narrow builds were removed.

As far as I know, this code is entirely dead now that unicodedata2 does not support these older versions of Python.

(context: I noticed this while diffing the test suite against the upstream tests as I organize a PR for #60)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant