force:source:push doesn't fail on missing meta file

[jeffhube]

Summary

If sfdx force:source:push fails due to a missing meta file, the exit code is 0, falsely indicating success.

Steps To Reproduce:

Repository to reproduce: dreamhouse-lwc

$ git clone https://github.com/dreamhouseapp/dreamhouse-lwc
$ cd dreamhouse-lwc
$ rm force-app/main/default/classes/FileUtilities.cls-meta.xml
$ sfdx force:source:push
[Error: ENOENT: no such file or directory, open '/home/jeff/dreamhouse-lwc/force-app/main/default/classes/FileUtilities.cls-meta.xml'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/jeff/dreamhouse-lwc/force-app/main/default/classes/FileUtilities.cls-meta.xml'
}
$ echo $?
0

Expected result

The exit code should be non-zero

Actual result

The exit code was zero

System Information

• Which shell/terminal are you using? bash

{
  "cliVersion": "sfdx-cli/7.192.2",
  "architecture": "wsl-x64",
  "nodeVersion": "node-v18.14.1",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 2.1.4 (core)",
    "@oclif/plugin-commands 2.2.10 (core)",
    "@oclif/plugin-help 5.2.7 (core)",
    "@oclif/plugin-not-found 2.3.21 (core)",
    "@oclif/plugin-plugins 2.4.0 (core)",
    "@oclif/plugin-search 0.0.14 (core)",
    "@oclif/plugin-update 3.1.6 (core)",
    "@oclif/plugin-version 1.2.1 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.30 (core)",
    "@oclif/plugin-which 2.2.16 (core)",
    "apex 2.2.2 (core)",
    "auth 2.7.7 (core)",
    "community 2.2.4 (core)",
    "custom-metadata 2.1.6 (core)",
    "data 2.3.6 (core)",
    "info 2.5.1 (core)",
    "limits 2.3.8 (core)",
    "org 2.4.6 (core)",
    "packaging 1.16.1 (core)",
    "schema 2.3.3 (core)",
    "settings 1.4.2 (core)",
    "signups 1.4.6 (core)",
    "source 2.5.5 (core)",
    "telemetry 2.1.3 (core)",
    "templates 55.4.4 (core)",
    "trust 2.4.4 (core)",
    "user 2.3.3 (core)",
    "@salesforce/sfdx-plugin-lwc-test 1.0.1 (core)"
  ],
  "osVersion": "Linux 5.15.90.1-microsoft-standard-WSL2",
  "shell": "bash",
  "rootPath": "/home/jeff/sfdx"
}

[github-actions]

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

[git2gus]

This issue has been linked to a new work item: W-12769219