Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf package install makes over 8 api calls per second while polling #2319

Closed
jeffhube opened this issue Jul 20, 2023 · 4 comments
Closed

sf package install makes over 8 api calls per second while polling #2319

jeffhube opened this issue Jul 20, 2023 · 4 comments
Labels
bug Issue or pull request that identifies or fixes a bug investigating We're actively investigating this issue validated Version information for this issue has been validated

Comments

@jeffhube
Copy link

Summary

When the sf package install command polls installation status, it makes an absurd number of api calls. The package install command ran for 7m23.384s and it made 3570 api calls, which is over 8 per second. On a slower package installation, this consumed the org's entire 15000 api call limit in ~30 minutes of polling.

Additionally, because of the update rate of the spinner, the command generates a significant amount of logs in ci systems. One package installation can result in over 1MB of logs.

Steps To Reproduce

sf org create scratch -f config/project-scratch-def.json -d
sf package install -p 04t*** -k *** -r -w 360

Expected result

The command makes api calls to poll package installation status at a reasonable rate (maximum one per second, preferably slower).

Actual result

The command makes api calls to poll package installation status at an average rate of over 8 per second.

System Information

Shell: Bash

{
  "cliVersion": "@salesforce/cli/2.0.2",
  "architecture": "wsl-x64",
  "nodeVersion": "node-v18.15.0",
  "osVersion": "Linux 5.15.90.1-microsoft-standard-WSL2",
  "shell": "bash",
  "rootPath": "/home/jeff/sf",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 2.3.1 (core)",
    "@oclif/plugin-commands 2.2.17 (core)",
    "@oclif/plugin-help 5.2.11 (core)",
    "@oclif/plugin-not-found 2.3.26 (core)",
    "@oclif/plugin-plugins 3.1.6 (core)",
    "@oclif/plugin-search 0.0.18 (core)",
    "@oclif/plugin-update 3.1.22 (core)",
    "@oclif/plugin-version 1.3.6 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.41 (core)",
    "@oclif/plugin-which 2.2.22 (core)",
    "@salesforce/cli 2.0.2 (core)",
    "apex 2.3.4 (core)",
    "auth 2.8.4 (core)",
    "data 2.4.5 (core)",
    "deploy-retrieve 1.13.5 (core)",
    "info 2.6.25 (core)",
    "limits 2.3.23 (core)",
    "login 1.2.15 (core)",
    "org 2.9.19 (core)",
    "packaging 1.20.1 (user)",
    "schema 2.3.17 (core)",
    "settings 1.4.17 (core)",
    "sobject 0.1.32 (core)",
    "source 2.10.22 (core)",
    "telemetry 2.2.1 (core)",
    "templates 55.5.2 (core)",
    "trust 2.4.27 (core)",
    "user 2.3.20 (core)"
  ]
}
@jeffhube jeffhube added the investigating We're actively investigating this issue label Jul 20, 2023
@github-actions
Copy link

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

@github-actions github-actions bot added the validated Version information for this issue has been validated label Jul 20, 2023
@mshanemc mshanemc added the bug Issue or pull request that identifies or fixes a bug label Jul 20, 2023
@git2gus
Copy link

git2gus bot commented Jul 20, 2023

This issue has been linked to a new work item: W-13797305

@mshanemc
Copy link
Contributor

aww, that sucks. We'll get it fixed in next week or so.

@mshanemc
Copy link
Contributor

this'll be in sf nightly tomorrow, RC on Wednesday the 26th, and latest the following Wednesday

@mshanemc mshanemc closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue or pull request that identifies or fixes a bug investigating We're actively investigating this issue validated Version information for this issue has been validated
Projects
None yet
Development

No branches or pull requests

2 participants