-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Minor changes of command line options #167
Comments
I also suggest including a I suggest specifying the version number in I know you have argued against feature creep in #101 (comment), but I still feel this feature is important to include in v0.2 to later make it easy to identify the version in use when more than one version has been released. I'm sorry I didn't suggest this much earlier. |
I 100% agree it's a good time to add version output now, so I am willing to include this in v0.2! Ideally we could get the version number from I don't mind changing Commenting out unused lines is perfectly reasonable. Regarding the |
Adding an optional -b BRANCH argument to build_examples.py to enable comparing to and restoring from any branch or commit. That will help when e.g. reversing an unfortunate commit of generated files. This solves part 2 of issue wireviz#167.
When used to "git diff", it is easy to write "build_examples.py diff" instead of "build_examples.py compare" by a mistake. Therefore, "diff" is now an alias to "compare" so both commands will work. This solves part 3 of issue wireviz#167.
It seems, that the current implementation ignores --generate-bom, and that parser.add_argument() code line is therefore commented out until it gets implemented to avoid any confusion. This solves part 1 of issue wireviz#167.
Add -V command line option (and --version as an alias) to both wireviz.py and build_examples.py that show version number. Move the version number from setup.py into __init__.py to access the same version number specification from all files needing it. This solves part 4 of issue wireviz#167.
Adding an optional -b BRANCH argument to build_examples.py to enable comparing to and restoring from any branch or commit. That will help when e.g. reversing an unfortunate commit of generated files. This solves part 2 of issue #167.
When used to "git diff", it is easy to write "build_examples.py diff" instead of "build_examples.py compare" by a mistake. Therefore, "diff" is now an alias to "compare" so both commands will work. This solves part 3 of issue #167.
It seems, that the current implementation ignores --generate-bom, and that parser.add_argument() code line is therefore commented out until it gets implemented to avoid any confusion. This solves part 1 of issue #167.
Add -V command line option (and --version as an alias) to both wireviz.py and build_examples.py that show version number. Move the version number from setup.py into __init__.py to access the same version number specification from all files needing it. This solves part 4 of issue #167.
It seems, however, that the current implementation ignores
--generate-bom
, and I suggest we comment out thatparser.add_argument()
code line until it gets implemented to avoid any confusion.Originally posted by @kvid in #111 (comment)
I also suggest adding an optional
-b BRANCH
argument tobuild_examples.py
to enable comparing to and restoring from any branch or commit. That will help when e.g. reversing an unfortunate commit of generated files.I have noticed that I quite often by a mistake write
build_examples.py diff
instead ofbuild_examples.py compare
- probably because I'm used to thegit diff
command. I therefore consider renaming thecompare
command todiff
or create an alias so both commands will work. What are your opinions?The text was updated successfully, but these errors were encountered: