Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow referencing a cable's/bundle's wires by color or label, if unambiguous #193

Closed
formatc1702 opened this issue Nov 11, 2020 · 3 comments
Milestone

Comments

@formatc1702
Copy link
Collaborator

formatc1702 commented Nov 11, 2020

Similar to how a connector's pins can be referenced by its ID (as per its entry in pins), or by its label (as per its entry in pinlabels) in case the label is unambiguous, a cable's/bundle's wire needs the ability to be referenced by its color (if unambiguous) since that is often the most natural way for the user. Additionally, cables should have a wirelabels attribute analogous to a connector's pinlabels, that can also be used for referencing.

Example 08's connection set should therefore work with either of the following:

  • Using the wire numbers (currently the only way):

    connections:
      -
        - Key: [S,R,T]
        - W1: [1,2,3]
  • Using the wire colors:

    connections:
      -
        - Key: [S,R,T]
        - W1: [WH, BN, GN]
  • Using the new wirelabels attribute:

    ...
    
    cables:
      W1:
        color_code: DIN
        wirecount: 3
        wirelabels: [one, two, three]
        ...
    
    connections:
      -
        - Key: [S,R,T]
        - W1: [one, two, three]
@formatc1702
Copy link
Collaborator Author

This is an expansion of #169 and there was a suggestion of using #, $ or similar to distinguish between sequential numbers, labels, etc.. but I can't seem to find it.

@kvid
Copy link
Collaborator

kvid commented Nov 11, 2020

This is an expansion of #169 and there was a suggestion of using #, $ or similar to distinguish between sequential numbers, labels, etc.. but I can't seem to find it.

I did suggest these prefixes in #10 (comment) (almost 5 months ago).

@formatc1702
Copy link
Collaborator Author

Thanks, searching for # and $ within GitHub did not work, and it didn't help that the comment was in an already merged PR.

I'm happy to discuss this feature as a new issue/PR, feel free to open one; I already have some thoughts on the matter.

For the time being, #194 would close this issue ignoring the above mentioned feature.

@formatc1702 formatc1702 changed the title Allow referencing a cable's/bundle's wires by color or label, if unambiguous [Feature] Allow referencing a cable's/bundle's wires by color or label, if unambiguous Nov 12, 2020
@formatc1702 formatc1702 added this to the v0.3 milestone Nov 14, 2020
formatc1702 added a commit that referenced this issue Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants