Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for line breaks #49

Closed
MikeCrookes opened this issue Jul 1, 2020 · 4 comments
Closed

[feature] Add support for line breaks #49

MikeCrookes opened this issue Jul 1, 2020 · 4 comments
Assignees

Comments

@MikeCrookes
Copy link

Would be great to be able to add line breaks into the fields as long descriptions can extend the output past normal screen width

@formatc1702
Copy link
Collaborator

This sounds reasonable. Which fields in particular are you thinking of?
Surely the notes fields... any other? I wouldn't want the code to become too cluttered with too many \n to <br> conversions all over the place.

@MikeCrookes
Copy link
Author

I'm not that familiar with all the fields (and what they do) but looking at the data classes I think may be useful for;

  • name
  • category
  • type
  • subtype
  • notes (as you suggested)

@formatc1702 formatc1702 changed the title Add support for line breaks [feature] Add support for line breaks Jul 5, 2020
@formatc1702 formatc1702 self-assigned this Jul 5, 2020
@formatc1702
Copy link
Collaborator

formatc1702 commented Jul 5, 2020

I have started some work in the feature/linebreaks branch.
Here's the YAML file I'm using to test.

I will add support for the following fields:

  • type
  • subtype
  • notes

name is the unique designator for a component and should be short and sweet (e.g. X1), no need for line breaks.
cagegory is only used internally, currently to distinguish between connectors and ferrules, as well as between cables and wire bundles. Thus the user does not need to edit this field.

Coming up: Replace line breaks with spaces for BOM output

@formatc1702
Copy link
Collaborator

Closed by #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants