Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename connector attributes #105

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Rename connector attributes #105

merged 3 commits into from
Jul 21, 2020

Conversation

formatc1702
Copy link
Collaborator

@formatc1702 formatc1702 commented Jul 19, 2020 •
edited
Loading

Closes #77.

PR is built on top of #102. May be reviewed before or after.
[Update: #102 is merged now]

@formatc1702 formatc1702 added this to the v0.2 milestone Jul 19, 2020
@formatc1702 formatc1702 force-pushed the feature/connector-attrib-names branch from f2efce3 to f885feb Compare July 19, 2020 21:23
Base automatically changed from feature/unify-connectors to dev July 20, 2020 06:23
@formatc1702 formatc1702 mentioned this pull request Jul 20, 2020
Merged
@formatc1702
Copy link
Collaborator Author

@kvid do you have any objections to this change?
Please don't feel pressured. My main thought is wanting to integrate this change soon so that any new changes can build on the new attribute names, which should take care of potentially ugly merge conflicts :)

@kvid
Copy link
Collaborator

kvid commented Jul 21, 2020

I have no objections at this tme, but have not had the time to read all the changes. The overall impression is good, but some of the changes are time consuming to verify, if done properly. I will not complain if you merge now. It is still possible to raise a new issue if I find something later. You decide, or maybe someone else can approve more quickly.

@formatc1702
Copy link
Collaborator Author

formatc1702 commented Jul 21, 2020 •
edited
Loading

All the relevant changes are in a1881eb and super straightforward.
The additional diff lines stem from the fact that I added #78 on top since it wasn't merged at that point, and the rest is just example rebuilding.
[Update]
Changed commit ref after rebasing, the comments re. #78 are irrelevant now. Hopefully everything went smoothly :)

@formatc1702 formatc1702 force-pushed the feature/connector-attrib-names branch from d503b2d to a69fc76 Compare July 21, 2020 20:12
@formatc1702 formatc1702 merged commit a69fc76 into dev Jul 21, 2020
@formatc1702 formatc1702 deleted the feature/connector-attrib-names branch July 21, 2020 20:12
@kvid kvid mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@formatc1702 @kvid