Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Islamic prayer times add-on #729

Open
islam2hamy opened this issue Aug 17, 2023 · 9 comments
Open

[Feature request] Islamic prayer times add-on #729

islam2hamy opened this issue Aug 17, 2023 · 9 comments

Comments

@islam2hamy
Copy link

Hello @forrestguice ,

May i ask you for a new add-on ( Islamic prayer times )

and this may help :
https://github.com/batoulapps/adhan-js

Thank you

@islam2hamy
Copy link
Author

@forrestguice can it be one of (sun data source ) ?

@forrestguice
Copy link
Owner

I'm very sorry but I don't foresee myself coding this add-on. I'm extremely hesitant to develop or maintain apps that I don't personally use. I think the maintenance part is particularly onerous (and not a responsibility to be taken lightly).

However, if someone else wants to develop and publish this, I'm willing to help them navigate that process, or even contribute code. I'm just not willing to take responsibility for the project myself.

To implement this, the add-on needs to query a content provider, perform some of its own calculations, and then display the results somehow. To supply alarms it will also need to implement its own "alarm provider" and advertise that in its manifest.

I think the quickest route would be to fork IntervalMidpoints as the starting point. Its already performing these steps, so its a matter of making modifications. It could also be coded from scratch (using favorite language/toolkit/library/whatever), the only important detail is that it uses the content-provider; https://developer.android.com/guide/topics/providers/content-provider-basics.

BTW, the "data source" extensions are mostly unrelated. These are useful if you want to replace the library that performs the sunrise/sunset calculations, etc, with some other library.

@forrestguice forrestguice changed the title [Feature request] new add-on [Feature request] Islamic prayer times add-on Nov 22, 2023
@islam2hamy
Copy link
Author

Thank you for your reply ,

BTW : your app already can calculate 4 of 5 prayer times (morning astronomical, solar none , sunset , evening astronomical )
The missing one for me is depending on the object shadow,

could you please just add an ability to this app to create alarm depending on object shadow ?

@forrestguice
Copy link
Owner

could you please just add an ability to this app to create alarm depending on object shadow ?

Yes. I'm willing to do that. 👍
I think its actually requested already in #331, but I didn't understand its potential use cases.

@islam2hamy
Copy link
Author

Thank You

@islam2hamy
Copy link
Author

islam2hamy commented Aug 10, 2024

Hello @forrestguice ,

Thank you for the new custom events based on "shadow length" it is very good ,
but i have found that in my case i need to acumelat the shadow length of 2 events , one depend on the shadow length and the other depend on the shadow for the sun event

could it be done in the next release ?

@forrestguice
Copy link
Owner

hrm, possibly, but I'm trying to understand this better.
Can you walk me through an example?

@islam2hamy
Copy link
Author

hrm, possibly, but I'm trying to understand this better. Can you walk me through an example?

Define the time for "Asr" as when the shadow of an object is the same length as the object itself plus the shadow length at midday (solar none)

@islam2hamy
Copy link
Author

IMG_٢٠٢٤٠٨١٥_٠٤٤٢٣٣

IMG_٢٠٢٤٠٨١٥_٠٤٤٣٥٢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants