Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - Building php master branch from source? #35

Open
drupol opened this issue Jul 11, 2021 · 12 comments · May be fixed by #104
Open

Question - Building php master branch from source? #35

drupol opened this issue Jul 11, 2021 · 12 comments · May be fixed by #104

Comments

@drupol
Copy link
Collaborator

drupol commented Jul 11, 2021

Hello,

Do you think it would be possible to have a php version like: php-master that would build from source the master branch of PHP ?

Thanks.

@jtojnar
Copy link
Member

jtojnar commented Jul 11, 2021 via email

@drupol
Copy link
Collaborator Author

drupol commented Sep 26, 2021

I'm ok to contribute, but I would require a bit of help on this :)

@aanderse
Copy link
Collaborator

I didn't see an obvious spot to grab nightlies. Where do you grab the source from? Currently in nixpkgs we grab from the php website:

https://github.com/NixOS/nixpkgs/blob/3329b3430739ed71a64c3931315367cf2c7f45e4/pkgs/development/interpreters/php/generic.nix#L274

@drupol
Copy link
Collaborator Author

drupol commented Sep 26, 2021

How about grabbing from the official git repo?

@aanderse
Copy link
Collaborator

See this PR for discussion. As @etu mentioned we weren't supposed to grab releases from github... but I'm not sure if that is still the case.

@jtojnar
Copy link
Member

jtojnar commented Sep 26, 2021

I think that is for released versions, it should not be a problem to use Git snapshots for testing purposes. And it should not be that hard to make the expression support both source types – just go through the official PHP docs on building (I assume there are some; would expect it to be similar to other autofoo set ups).

@etu
Copy link
Collaborator

etu commented Sep 27, 2021

Since the developments where they have changed their official developments to be hosted on GitHub I think this might have changed things as well.

It would be nice to be able to easily provide development builds, so if we switched all the builds to grab from GitHub tags, we could do that easily. But then it's not the "official release tarball".

The question is how much that matters?

@drupol
Copy link
Collaborator Author

drupol commented Oct 3, 2021

What's the battle plan then ? :)

@jtojnar
Copy link
Member

jtojnar commented Oct 3, 2021

Someone needs to write it, should not be that hard.

@drupol
Copy link
Collaborator Author

drupol commented Oct 3, 2021

If you give me some directions, I might give it a try :)

@jtojnar
Copy link
Member

jtojnar commented Oct 3, 2021

It should be just duplicating the php73 code in pkgs/phps.nix. Only for base, you would have something like

  baseMaster = (prev.callPackage generic (_mkArgs {
    version = "fooo";
    sha256 = "0000000000000000000000000000000000000000000000000000000000000000";
  })).overrideAttrs (attrs: {
    src = /* … */;
  });

And if that does not work, make php builder accept a src ? null attribute, and use that when not null. (For development, you can point the flake to your local Nixpkgs checkout using nix flake update --override-input nixpkgs ~/Projects/nixpkgs, will need to run it each time you modify Nixpkgs code.)

@jtojnar
Copy link
Member

jtojnar commented May 15, 2022

#104 is an attempt at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants